E2E: add registered shopper checkout test #28867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsinger
added
category: E2E
package: @woocommerce/e2e-core-tests
rrennick
reviewed
Jan 20, 2021
| const runCheckoutRegisteredPageTest = () => { | ||
| describe('Checkout page', () => { | ||
| beforeAll(async () => { | ||
| await merchant.login(); |
There was a problem hiding this comment.
The existing shopper tests depend on these settings already being set. If we were to update all the shopper tests to include enabling these settings using the browser it would add a significant amount of runtime. I think we should defer making the shopper test atomic until we have a function to do it with the api package.
rrennick
reviewed
Jan 20, 2021
| return orderId = orderReceivedText.split(/(\s+)/)[6].toString(); | ||
| }); | ||
|
|
||
| it('store owner can confirm the order was received', async () => { |
There was a problem hiding this comment.
Do we need to have the merchant check for the order in every test that creates an order? A couple alternatives for discussion:
- If so, this would be a good opportunity to turn the merchant order check into a function.
- The api could be used to verify that orders in additional tests were created.
lsinger
force-pushed
the
add/e2e-shopper-registered-checkout
branch
from
32d4db5
to
1bafa98
Compare
|
@rrennick thanks for your thoughts -- I've adjusted the approach accordingly. Would you mind taking another look? |
woocommercebot
added
release: add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #27883.
How to test the changes in this Pull Request:
Other information:
Changelog entry
N/A