Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes issue #30828 by correcting the selector for the scroll target in checkout scroll_to_notices() function.
How to test the changes in this Pull Request:
The function
scroll_to_notices
incheckout.js
attempst to scroll to an element matching the selector:.woocommerce-NoticeGroup-updateOrderReview, .woocommerce-NoticeGroup-checkout
(which itself is prepended to the checkout form insubmit_error
). If for whatever reason no elements match this selector, the fallback is to scroll to.form.checkout
before the fix.You can test this locally by intentionlly changing the class names in either function such that the fallback is attempted, and this will not scroll to any element.
Other information:
Changelog entry
FOR PR REVIEWER ONLY: