Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path from "include currency-info.php" in locale-info.php #31036

Merged
merged 2 commits into from Oct 28, 2021

Conversation

Konamiman
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This pull request is the same as #30935, but targeting the release/5.9 branch for inclusion in WooCommerce 5.9. Same testing instructions and changelog entry.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@Konamiman Konamiman added this to the 5.9.0 milestone Oct 27, 2021
@Konamiman Konamiman self-assigned this Oct 27, 2021
Copy link
Contributor

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update. Thanks!

i18n/locale-info.php Outdated Show resolved Hide resolved
Copy link
Contributor

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@Konamiman Konamiman merged commit 52a0ffc into release/5.9 Oct 28, 2021
@Konamiman Konamiman deleted the fix/currency-info-include branch October 28, 2021 09:58
@Konamiman Konamiman added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Oct 28, 2021
@github-actions
Copy link
Contributor

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@Konamiman
Copy link
Contributor Author

Konamiman commented Oct 28, 2021

Merged into release/5.9 for inclusion in WooCommerce 5.9 RC 2. Needs to be cherry-picked into trunk.

@Konamiman
Copy link
Contributor Author

No need to cherrypick to trunk as the change has been already applied there.

@Konamiman Konamiman removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants