Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes the star icon font #31670

Merged
merged 12 commits into from Mar 20, 2024
Merged

Removes the star icon font #31670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9ede2b6
removes the star font
erikyo Dec 21, 2021
3d1c73a
updates custom templates stylesheets
erikyo Jan 18, 2022
82e0464
adds woff2 font format to themes customized stylesheets
erikyo Jan 18, 2022
25f35b0
fix the star font size diff
erikyo Feb 18, 2022
48ac782
removes WooCommerce.eot and SVG file that are no longer needed and up…
erikyo May 18, 2022
462a148
Optimized font import
erikyo Mar 4, 2024
e774b40
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Mar 4, 2024
e2d5408
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Mar 5, 2024
4d8daa1
Svg font minification (WooCommerce.svg)
erikyo Mar 5, 2024
381dafa
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Mar 5, 2024
8d8e7f5
"star" font phasing out
erikyo Mar 11, 2024
ce03a12
Removes the `.eot` font file since nowdays it's completely useless
erikyo Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/woocommerce-blocks/assets/css/style.scss
View file
Open in desktop
Expand Up @@ -109,7 +109,7 @@ body.wc-block-product-gallery-modal-open {
line-height: 1.618;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;
margin: 0 auto;
text-align: left;
Expand Down
2 changes: 1 addition & 1 deletion ...ns/woocommerce-blocks/assets/js/atomic/blocks/product-elements/product-reviews/style.scss
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@
line-height: 1.618;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;

&::before {
Expand Down
4 changes: 2 additions & 2 deletions plugins/woocommerce-blocks/assets/js/atomic/blocks/product-elements/rating-stars/style.scss
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
line-height: 1.618;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;
text-align: left;

Expand Down Expand Up @@ -74,7 +74,7 @@
line-height: 1.618;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;
-webkit-text-stroke: 2px var(--wp--preset--color--black, #000);
&::before {
Expand Down
4 changes: 2 additions & 2 deletions plugins/woocommerce-blocks/assets/js/base/components/product-rating/style.scss
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ $line-height: 1.618;
line-height: $line-height;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;

&.wc-block-grid__product-rating__stars {
Expand Down Expand Up @@ -86,7 +86,7 @@ $line-height: 1.618;
line-height: $line-height;
font-size: 1em;
/* stylelint-disable-next-line font-family-no-missing-generic-family-keyword */
font-family: star;
font-family: WooCommerce;
font-weight: 400;
-webkit-text-stroke: 2px var(--wp--preset--color--black, #000);
&::before {
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce-blocks/assets/js/base/components/reviews/review-list-item/style.scss
View file
Open in desktop
Expand Up @@ -176,7 +176,7 @@
height: 1em;
line-height: 1;
width: 5.3em;
font-family: star; /* stylelint-disable-line */
font-family: WooCommerce; /* stylelint-disable-line */
font-weight: 400;
}

Expand Down
Binary file removed plugins/woocommerce/assets/fonts/WooCommerce.eot
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion plugins/woocommerce/assets/fonts/WooCommerce.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified plugins/woocommerce/assets/fonts/WooCommerce.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified plugins/woocommerce/assets/fonts/WooCommerce.woff
View file
Open in desktop
Binary file not shown.
Binary file added plugins/woocommerce/assets/fonts/WooCommerce.woff2
View file
Open in desktop
Binary file not shown.
Binary file removed plugins/woocommerce/assets/fonts/star.eot
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/31670-remove-star-icon
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: minor
Type: performance

Removes star font
18 changes: 7 additions & 11 deletions plugins/woocommerce/client/legacy/css/_fonts.scss
View file
Open in desktop
Expand Up @@ -4,22 +4,18 @@
*/
@font-face {
font-family: 'star';
src: url('../fonts/star.eot');
src: url('../fonts/star.eot?#iefix') format('embedded-opentype'),
url('../fonts/star.woff') format('woff'),
url('../fonts/star.ttf') format('truetype'),
url('../fonts/star.svg#star') format('svg');
src: url('../fonts/WooCommerce.woff2') format('woff2'),
url('../fonts/WooCommerce.woff') format('woff'),
url('../fonts/WooCommerce.ttf') format('truetype');
font-weight: normal;
font-style: normal;
}

@font-face {
font-family: 'WooCommerce';
src: url('../fonts/WooCommerce.eot');
src: url('../fonts/WooCommerce.eot?#iefix') format('embedded-opentype'),
url('../fonts/WooCommerce.woff') format('woff'),
url('../fonts/WooCommerce.ttf') format('truetype'),
url('../fonts/WooCommerce.svg#WooCommerce') format('svg');
src: url('../fonts/WooCommerce.woff2') format('woff2'),
url('../fonts/WooCommerce.woff') format('woff'),
url('../fonts/WooCommerce.ttf') format('truetype');
font-weight: normal;
font-style: normal;
}
}
24 changes: 2 additions & 22 deletions plugins/woocommerce/client/legacy/css/twenty-nineteen.scss
View file
Open in desktop
Expand Up @@ -13,27 +13,7 @@ $highlights-color: #0073aa;
/**
* Fonts
*/
@font-face {
font-family: 'star';
src: url('../fonts/star.eot');
src: url('../fonts/star.eot?#iefix') format('embedded-opentype'),
url('../fonts/star.woff') format('woff'),
url('../fonts/star.ttf') format('truetype'),
url('../fonts/star.svg#star') format('svg');
font-weight: normal;
font-style: normal;
}

@font-face {
font-family: 'WooCommerce';
src: url('../fonts/WooCommerce.eot');
src: url('../fonts/WooCommerce.eot?#iefix') format('embedded-opentype'),
url('../fonts/WooCommerce.woff') format('woff'),
url('../fonts/WooCommerce.ttf') format('truetype'),
url('../fonts/WooCommerce.svg#WooCommerce') format('svg');
font-weight: normal;
font-style: normal;
}
@import "fonts";

/**
* Global elements
Expand Down Expand Up @@ -226,7 +206,7 @@ ul.products {
line-height: 1;
font-size: 1em;
width: 5.4em;
font-family: 'star';
font-family: WooCommerce;

&::before {
content: '\73\73\73\73\73';
Expand Down
26 changes: 2 additions & 24 deletions plugins/woocommerce/client/legacy/css/twenty-seventeen.scss
View file
Open in desktop
Expand Up @@ -7,29 +7,7 @@
/**
* Fonts
*/
@font-face {
font-family: "star";
src: url("../fonts/star.eot");
src:
url("../fonts/star.eot?#iefix") format("embedded-opentype"),
url("../fonts/star.woff") format("woff"),
url("../fonts/star.ttf") format("truetype"),
url("../fonts/star.svg#star") format("svg");
font-weight: normal;
font-style: normal;
}

@font-face {
font-family: "WooCommerce";
src: url("../fonts/WooCommerce.eot");
src:
url("../fonts/WooCommerce.eot?#iefix") format("embedded-opentype"),
url("../fonts/WooCommerce.woff") format("woff"),
url("../fonts/WooCommerce.ttf") format("truetype"),
url("../fonts/WooCommerce.svg#WooCommerce") format("svg");
font-weight: normal;
font-style: normal;
}
@import "fonts";

/**
* Mixins
Expand Down Expand Up @@ -225,7 +203,7 @@ ul.products {
line-height: 1;
font-size: 1em;
width: 5.4em;
font-family: "star";
font-family: WooCommerce;

&::before {
content: "\73\73\73\73\73";
Expand Down
26 changes: 2 additions & 24 deletions plugins/woocommerce/client/legacy/css/twenty-twenty-one.scss
View file
Open in desktop
Expand Up @@ -13,29 +13,7 @@ $highlights-color: #88a171;
/**
* Fonts
*/
@font-face {
font-family: star;
src: url(../fonts/star.eot);
src:
url(../fonts/star.eot?#iefix) format("embedded-opentype"),
url(../fonts/star.woff) format("woff"),
url(../fonts/star.ttf) format("truetype"),
url(../fonts/star.svg#star) format("svg");
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: WooCommerce;
src: url(../fonts/WooCommerce.eot);
src:
url(../fonts/WooCommerce.eot?#iefix) format("embedded-opentype"),
url(../fonts/WooCommerce.woff) format("woff"),
url(../fonts/WooCommerce.ttf) format("truetype"),
url(../fonts/WooCommerce.svg#WooCommerce) format("svg");
font-weight: 400;
font-style: normal;
}
@import "fonts";

/**
* Global elements
Expand Down Expand Up @@ -398,7 +376,7 @@ ul.products {
line-height: 1;
font-size: 1em;
width: 5.4em;
font-family: star;
font-family: WooCommerce;
margin-bottom: 0.7rem;

&::before {
Expand Down
26 changes: 2 additions & 24 deletions plugins/woocommerce/client/legacy/css/twenty-twenty-three.scss
View file
Open in desktop
@@ -1,29 +1,7 @@
/**
* Fonts
*/
@font-face {
font-family: star;
src: url(../fonts/star.eot);
src:
url(../fonts/star.eot?#iefix) format("embedded-opentype"),
url(../fonts/star.woff) format("woff"),
url(../fonts/star.ttf) format("truetype"),
url(../fonts/star.svg#star) format("svg");
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: WooCommerce;
src: url(../fonts/WooCommerce.eot);
src:
url(../fonts/WooCommerce.eot?#iefix) format("embedded-opentype"),
url(../fonts/WooCommerce.woff) format("woff"),
url(../fonts/WooCommerce.ttf) format("truetype"),
url(../fonts/WooCommerce.svg#WooCommerce) format("svg");
font-weight: 400;
font-style: normal;
}
@import "fonts";

@import "mixins";
@import "animation";
Expand Down Expand Up @@ -440,7 +418,7 @@
height: 1em;
line-height: 1;
width: 5.4rem;
font-family: star;
font-family: WooCommerce;
font-style: normal;
color: var(--wp--preset--color--contrast);
margin: 1rem auto 0.7rem auto;
Expand Down
26 changes: 2 additions & 24 deletions plugins/woocommerce/client/legacy/css/twenty-twenty-two.scss
View file
Open in desktop
@@ -1,29 +1,7 @@
/**
* Fonts
*/
@font-face {
font-family: star;
src: url(../fonts/star.eot);
src:
url(../fonts/star.eot?#iefix) format("embedded-opentype"),
url(../fonts/star.woff) format("woff"),
url(../fonts/star.ttf) format("truetype"),
url(../fonts/star.svg#star) format("svg");
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: WooCommerce;
src: url(../fonts/WooCommerce.eot);
src:
url(../fonts/WooCommerce.eot?#iefix) format("embedded-opentype"),
url(../fonts/WooCommerce.woff) format("woff"),
url(../fonts/WooCommerce.ttf) format("truetype"),
url(../fonts/WooCommerce.svg#WooCommerce) format("svg");
font-weight: 400;
font-style: normal;
}
@import "fonts";

@import "mixins";
@import "animation";
Expand Down Expand Up @@ -435,7 +413,7 @@ $tt2-gray: #f7f7f7;
height: 1em;
line-height: 1;
width: 5.4rem;
font-family: star;
font-family: WooCommerce;
color: var(--wp--preset--color--secondary);
margin: 1rem auto 0.7rem auto;

Expand Down
24 changes: 2 additions & 22 deletions plugins/woocommerce/client/legacy/css/twenty-twenty.scss
View file
Open in desktop
Expand Up @@ -15,27 +15,7 @@ $highlights-color: #cd2653;
/**
* Fonts
*/
@font-face {
font-family: star;
src: url(../fonts/star.eot);
src: url(../fonts/star.eot?#iefix) format("embedded-opentype"),
url(../fonts/star.woff) format("woff"),
url(../fonts/star.ttf) format("truetype"),
url(../fonts/star.svg#star) format("svg");
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: WooCommerce;
src: url(../fonts/WooCommerce.eot);
src: url(../fonts/WooCommerce.eot?#iefix) format("embedded-opentype"),
url(../fonts/WooCommerce.woff) format("woff"),
url(../fonts/WooCommerce.ttf) format("truetype"),
url(../fonts/WooCommerce.svg#WooCommerce) format("svg");
font-weight: 400;
font-style: normal;
}
@import "fonts";

/**
* Global elements
Expand Down Expand Up @@ -312,7 +292,7 @@ ul.products {
line-height: 1;
font-size: 1em;
width: 5.4em;
font-family: star;
font-family: WooCommerce;
margin-bottom: 0.7rem;

&::before {
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/client/legacy/css/woocommerce.scss
View file
Open in desktop
Expand Up @@ -804,7 +804,7 @@ p.demo_store,
line-height: 1;
font-size: 1em;
width: 5.4em;
font-family: "star";
font-family: WooCommerce;

&::before {
content: "\73\73\73\73\73";
Expand Down