Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync/paypal security release #32057

Merged
merged 8 commits into from Mar 10, 2022
Merged

Sync/paypal security release #32057

merged 8 commits into from Mar 10, 2022

Conversation

jonathansadowski
Copy link
Contributor

@jonathansadowski jonathansadowski commented Mar 10, 2022 •
edited

All Submissions:

Changes proposed in this Pull Request:

This PR syncs the changes in https://plugins.trac.wordpress.org/changeset/2692138

How to test the changes in this Pull Request:

  1. Verify that the changes here are similar to those synced in https://plugins.trac.wordpress.org/changeset/2692138

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

This PR includes the changelog updates, therefore an entry is not required.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

jorgeatorres and others added 7 commits March 10, 2022 10:48
@jorgeatorres @jonathansadowski
Make PayPal Standard PDT notification validation more strict
8bb2b57
@Konamiman @jonathansadowski
Create a new WC_Gateway_Paypal_Response::check_response_for_order method
3e1acd1 
Adding a new parameter to the existing check_response method could cause
backwards incompatibility issues in inherited classes, so we deprecate
the old method and create a new one instead.
@vedanshujain @barryhughes @jonathansadowski
Fix object reference
b1b68f5 
Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com>
@peterfabian @jonathansadowski
Receiver email set separately for bw compat
95ec1fc
@peterfabian @jonathansadowski
Fixed the order id fetching
ce37800
@peterfabian @jonathansadowski
Fixed docs.
8d8a556
@barryhughes @jonathansadowski
Update plugins/woocommerce/includes/gateways/paypal/includes/class-wc…
8be6eb4 
…-gateway-paypal-pdt-handler.php
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 10, 2022
@jonathansadowski jonathansadowski marked this pull request as ready for review March 10, 2022 17:04
@jonathansadowski jonathansadowski requested review from a team and roykho and removed request for a team March 10, 2022 17:08
roykho
roykho approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

So after merging this I think some pending items would be:

  • Cherry pick this into release/6.3 branch.
  • Cut a 6.3.1 release based on release/6.3.

@jonathansadowski
Copy link
Contributor Author

LGTM! Good job!

So after merging this I think some pending items would be:

  • Cherry pick this into release/6.3 branch.
  • Cut a 6.3.1 release based on release/6.3.

Thanks for the review @roykho. Yeah, I have a series of branches pending to cut GH releases for each of the versions mentioned. All of them are based on tags for consistency, so I'll probably just replace the release/6.3 branch once those are ready for review.

@roykho roykho merged commit 31b2bc2 into trunk Mar 10, 2022
@roykho roykho deleted the sync/paypal-security-release branch March 10, 2022 17:39
@github-actions github-actions bot added this to the 6.4.0 milestone Mar 10, 2022
@github-actions
Copy link
Contributor

Hi @roykho, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add changelog label
  • Add the release: add testing instructions label

@ObliviousHarmony ObliviousHarmony modified the milestones: 6.4.0, 6.0.0, 6.3.0 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roykho roykho roykho approved these changes

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jonathansadowski @roykho @ObliviousHarmony @jorgeatorres @Konamiman @vedanshujain @peterfabian @barryhughes