New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Finnish translation #3225

wants to merge 1 commit into
base: master


None yet
5 participants

ottok commented May 22, 2013

I merged the Finnish translation from on top of the translations in upstream WooCommerce (this repo). After that I applied the latest POT files and fine tuned files manually.

Merging done using commmands:

msgcat --use-first -o woocommerce-fi.po woocommerce-fi.po.orig woothemes_fi.po
msgcat --use-first -o woocommerce-admin-fi.po woocommerce-admin-fi.po.orig woothemes_fi.po

This comment has been minimized.


arhipaiva commented May 22, 2013

As the original author of the Finnish translator I wonder what is the point of this merge and pull request?

  1. Made a random check of 4 alterations [in -admin file] supposedly made by ottok. None were modified in any way except this: the author of those [unchanged] strings was changed. This is not very polite. 2) The credits were changed in such a way that suggest "hijacking" the project [Language-Team]. It includes a bunch of names who have in no way participated in the translation as it stands.

In my opinion this pull request has issues. There are proper, established ways to proceed.

@ottok I propose the following:
When there is a need to modify the translation, that work should be done in Finland. There is a forum for it - in which both me and you "ottok" are members of. After an agreement, a modified file should be presented as a pull request here.
I see no intelligent reason to "competitive" updates, one nullifying the other in succession. Do you?

In order to keep WC Finnish translation up to date and to keep the translation coherent (with unified form) I have prepared an update to my translation: from 2.0.7 to 2.1.X. Up to date: POT-Creation-Date: 2013-05-22 21:16:01+00:00. It supersedes this pull request.
Pull request: #3226

If there is later need to include any alterations suggested by ottok another pull request should be made later, after discussion in Finland.


This comment has been minimized.


mikejolley commented May 23, 2013

Ok - I won't merge this so you guys can talk it out on your forums when its finnish-ed.

:D cc/ @coenjacobs

@mikejolley mikejolley closed this May 23, 2013


This comment has been minimized.

ottok commented May 23, 2013

The point of this merge request is to merge the translations of many people done at Transifex with the execellent work of Arhi here upstream. No point in having two locations with translations of the same program.

It seems that Arhi alone has done the translations so well that all the work at Transifex was unnecessary and no merging is needed, we can just but the Transifex version in a digital waste bin..


This comment has been minimized.


coenjacobs commented May 23, 2013

This again proves the point that we could really use a GlotPress install to power our translations. Will look into this shortly, cause the Finnish translation is not the only one with multiple people work on it.


This comment has been minimized.


scottbasgaard commented May 23, 2013

@ottok @coenjaocbs GlotPress +1


This comment has been minimized.


arhipaiva commented May 24, 2013

The mentioned Transifex team never completed its work. In fall/august 2012 work topped at 70% completion and stands now at 45%. My independent translation (from Dec 2012) has been 100% from the start and frequently updated.

It was a pretty gross attempt to grab a 100% complete quality controlled translation and take it over by or attribute to an unrelated team which never completed the job and which seems pretty dead. Whether ottok was/is a member of this Transifex team and whether or not he represented this team I have no knowledge of. Maybe it was just an unfortunate brain fart from him. I hope.

For anyone interested in working on the Finnish WC translation, this is the forum thread in Finnish, including comments from ottok:

This episode appears to be closed now.
When WC GlotPress is up, I am in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment