Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback image payments task gateway icons #32773

Merged
merged 3 commits into from Apr 28, 2022
Merged

Add fallback image payments task gateway icons #32773

merged 3 commits into from Apr 28, 2022

Conversation

ilyasfoo
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #32575.

How to test the changes in this Pull Request:

  1. In your local, set store country to US and don't select WCPay during onboarding
  2. Make sure Stripe plugin isn't set up
  3. Hardcode this condition to true so that it'll load local gateway config
  4. Change Stripe 72x72 image URL to an non-existent URL, such as stripe1234.png
  5. Go to Set up payments task
  6. Observe Stripe gateway image loads the fallback image since the request is returning 404

image

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested a review from a team April 26, 2022 04:23
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 26, 2022
chihsuan
chihsuan approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested well! 🚢

@ilyasfoo ilyasfoo merged commit 1e6d45d into trunk Apr 28, 2022
@ilyasfoo ilyasfoo deleted the dev/32575-add-generic-fallback-image-payments-task branch April 28, 2022 05:31
@github-actions github-actions bot added this to the 6.6.0 milestone Apr 28, 2022
@github-actions
Copy link
Contributor

Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Closed
This was referenced Jul 4, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chihsuan chihsuan chihsuan approved these changes

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

Add generic payment method icon as fallback in payments task
2 participants
@ilyasfoo @chihsuan