Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add woo install timestamp to server experimental assignment requests #33300

Merged
merged 2 commits into from Jun 3, 2022

Conversation

joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Jun 2, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes (part of) #33295 .

How to test the changes in this Pull Request:

  1. Create a new site
  2. Add this as a plugin:
add_filter( 'pre_http_request', function( $bool, $parsed_args, $url ) {
	$logger = wc_get_logger();
	$logger->debug( $url );
	$logger->debug(
		$url,
		array( 'source' => 'experiments' )
	);
	return $bool;
}, 10, 3 );
  1. Visit the homepage
  2. Visit the logs page wp-admin/admin.php?page=wc-status&tab=logs
  3. Check the experiments-* log
  4. See that woo_wcadmin_install_timestamp is in the URL with the correct timestamp

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm nx changelog <project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joshuatf joshuatf self-assigned this Jun 2, 2022
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 2, 2022
@botwoo
Copy link
Collaborator

botwoo commented Jun 2, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Add changelog entry d87cccb
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

louwie17
louwie17 previously approved these changes Jun 2, 2022
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Tested well, thanks for adding this, I seem to get assigned an experiment on Jurassic :)

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joshuatf joshuatf added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Jun 3, 2022
@joshuatf joshuatf merged commit 21f7cea into trunk Jun 3, 2022
@joshuatf joshuatf deleted the fix/33295 branch June 3, 2022 12:25
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Hi @joshuatf, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

jonathansadowski added a commit that referenced this pull request Jun 3, 2022
* Update required WP version

See https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/composer.json#L17

* Add check for post_types key #33179

Add check for post_types key

* add changelog

* Update changelog and readme for cherry-picked PR #33180

* Remove changelog file for cherry-picked PR #33180

* Update version to 6.6.0-rc.2 in woocommerce.php

* Add woo install timestamp to server experimental assignment requests

* Add changelog entry

* Update changelog and readme for cherry-picked PR #33300

* Remove changelog file for cherry-picked PR #33300

Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: Luigi <gigitux@gmail.com>
Co-authored-by: Joshua Flowers <joshuatf@gmail.com>
jonathansadowski added a commit that referenced this pull request Jun 3, 2022
* Remove changelog file for cherry-picked PR #33180

* Remove changelog file for cherry-picked PR #33300
@jonathansadowski jonathansadowski modified the milestones: 6.7.0, 6.6.0 Jun 3, 2022
@jonathansadowski jonathansadowski removed the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Jun 3, 2022
@jonathansadowski
Copy link
Contributor

This has been cherry-picked into the 6.6 release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants