Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated @automattic/tour-kit to 1.1.1 which has live resize functionality #33452

Merged
merged 1 commit into from Jun 16, 2022

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Jun 16, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds live resize functionality to the tour kit spotlight so that it follows the referenced element even when it moves or resizes.

How to test the changes in this Pull Request:

Same as #33268

  1. Install and activate WCA Test Helper
  2. Go to Tools > WCA Test Helper > Features
  3. Enable experimental-product-tour
  4. Go to Tools > WCA Test Helper > Experiments
  5. Add woocommerce_products_tour to treatment
  6. Go to WooCommerce > Home
  7. Click on "Add My Products" > Start with a template
  8. Select physical products and click "Go"
  9. Click Next button
  10. Observe the spotlight feature as per recording
Code_AfvJqN14iW.mp4

Notice that at the start of the recording I insert an element before the spotlit input field and the spotlight moves along with it. Previously that would not have updated. This also applies to notices that show up after the page has loaded.

The snippet I used to add a <p> element before the spotlit element looks like this:
document.querySelector("input.wp-tour-kit-spotlit").parentElement.insertBefore(document.createElement("p", "a"), document.querySelector("input.wp-tour-kit-spotlit"))

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 16, 2022
@rjchow rjchow requested a review from a team June 16, 2022 07:25
@rjchow rjchow marked this pull request as ready for review June 16, 2022 07:25
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjchow Thanks for working on this. Tested well and looks perfect!

@botwoo
Copy link
Collaborator

botwoo commented Jun 16, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Updated @automattic/tour-kit to 1.1.1 which has live resize functiona… a369815
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

@rjchow rjchow merged commit a78670b into trunk Jun 16, 2022
@rjchow rjchow deleted the add/tour-kit-live-resize branch June 16, 2022 07:49
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 16, 2022
@github-actions
Copy link
Contributor

Hi @rjchow, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: @woocommerce/components issues related to @woocommerce/components plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants