Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the trash can icon in the attribute list #35133

Merged
merged 1 commit into from Oct 18, 2022

Conversation

mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Oct 17, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #35092.

How to test the changes in this Pull Request:

  1. Locate a created product with attributes.
  2. Visit /wp-admin/admin.php?page=wc-admin&path=/product/{productId} replace productId with your id
  3. A close-small icon should be shown to remove the attribute instead the trash-can icon.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mdperez86 mdperez86 added the focus: new product ux revamped product management experience label Oct 17, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Oct 17, 2022
@mdperez86 mdperez86 requested a review from a team October 17, 2022 19:01
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 4542b56

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests18800201900m 44s
E2E Tests186003018915m 7s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mdperez86 mdperez86 self-assigned this Oct 17, 2022
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Tested well and looks good :)

@mdperez86 mdperez86 merged commit c79af1a into trunk Oct 18, 2022
@mdperez86 mdperez86 deleted the enhancement/35092-replace-trash-icon branch October 18, 2022 19:05
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 18, 2022
@github-actions
Copy link
Contributor

Hi @mdperez86, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Replace the trash can icon in the list item component
2 participants