Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/e2e environment test failures #35679

Merged
merged 3 commits into from Nov 22, 2022
Merged

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Nov 22, 2022

All Submissions:

Changes proposed in this Pull Request:

This updates Playwright to the latest version and explicitly sets PHP version for wp-env use to try to minimize test flakiness.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 22, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 47a65f5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 56s
E2E Tests186006019218m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around on this @lanej0! Changes look good to me.

@zhongruige zhongruige merged commit fd7fc35 into trunk Nov 22, 2022
@zhongruige zhongruige deleted the fix/e2e-environment-test-failures branch November 22, 2022 23:16
@github-actions github-actions bot added this to the 7.3.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants