Another set of migrations from set-output to GITHUB_OUTPUT

[samueljseay]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

set-output is deprecated and will be removed early next year. This includes another set of migrations from set-output such as in #35799

Also note that saving these files ran Prettier against them too so where the formatting was incorrect that has also been fixed.

Note: I'm introducing these in chunks to make the test effort easier and to limit the risk of introducing wide ranging changes all at once.

How to test the changes in this Pull Request:

1. You will need a fork of WooCommerce with Actions enabled. See testing instructions in Remove some usages of set-output #35799 if you need help with this.

2. Merge this branch into trunk of your fork

3. Test the is-community script. Create an arbitrary PR into your fork under your account. This should not be marked as a community contribution, check the CI check worked correctly and there were no errors. To test the case for community contributors, ask a team mate to submit an arbitrary PR to your fork. It should be marked as community contribution as long as they don't have write access to your fork.

4. In your fork, check what the stable version of WooCommerce is (in the readme.txt). Create a release in releases that is a version less than stable. Check under actions you should be able to see a "post release" action has been run. It should have a skipped step because the version released is less than current stable. Now create a new release that is greater than the stable release version, this workflow should run all steps and none should be skipped. (for both cases obviously no errors should be shown).

5. For the cherry pick, I think its quite difficult to test. @jonathansadowski have you tested cherry pick in PRs before?

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[github-actions]

Test Results Summary

Commit SHA: 574f047

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 54s
E2E Tests	187	0	0	6	0	193	17m 34s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[samueljseay]

Just a heads up, you'll still see the deprecation warning when core.setOutput is run because even as of latest it still does a set-output command after doing the command to write to GITHUB_OUTPUT

[samueljseay]

See actions/toolkit#1218

[roykho]

Seeing an error on community-label.yml workflow.

Run node .github/workflows/scripts/is-community-contributor.js
node:internal/modules/cjs/loader:988
  throw err;
  ^

Error: Cannot find module '@action/core'
Require stack:
- /home/runner/work/woocommerce-fork/woocommerce-fork/.github/workflows/scripts/is-community-contributor.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/home/runner/work/woocommerce-fork/woocommerce-fork/.github/workflows/scripts/is-community-contributor.js:3:14)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:8[6](https://github.com/roykho/woocommerce-fork/actions/runs/3651683553/jobs/6169190334#step:6:7)[8](https://github.com/roykho/woocommerce-fork/actions/runs/3651683553/jobs/6169190334#step:6:9):[12](https://github.com/roykho/woocommerce-fork/actions/runs/3651683553/jobs/6169190334#step:6:13))
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/woocommerce-fork/woocommerce-fork/.github/workflows/scripts/is-community-contributor.js'
  ]
}

[samueljseay]

Whoops! sorry for the typo @roykho should be good now.

[roykho]

Getting this error on this step "If community PR, assign a reviewer".

Run shufo/auto-assign-reviewer-by-files@f5f3db9ef06bd72ab6978996988c6462cbdaabf6
  with:
    config: .github/project-community-pr-assigner.yml
Error: Input required and not supplied: token

[samueljseay]

@roykho thats not related to this. Thats because that action uses a token set in our repo. Probably I missed this as a testing step but you could add a secret called PR_ASSIGN_TOKEN to your fork.. Maybe a PAT generated in your account. I'm not sure though if that will succeed I haven't tested it.

Probably it doesn't matter though, the fact that this action is run in your fork is proof enough for me anyway

[roykho]

I think fixing this last issue I found should take care of it.

[roykho]

LGTM!