Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TikTok in OBW #35924

Merged
merged 2 commits into from Dec 14, 2022
Merged

Disable TikTok in OBW #35924

merged 2 commits into from Dec 14, 2022

Conversation

chihsuan
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

See pbIJXs-2Jz-p2#comment-5666

Set is_visible prop of TikTok to false

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Navigate to WooCommerce > Settings > Advanced > woocommerce.com.
  2. Disable (untick) Enable tracking and Show Suggestions.
  3. Begin the onboarding, by triggering the Help menu and clicking Setup Wizard.
  4. Proceed through the onboarding. At the Business Details screen, ensure TikTok is NOT listed as a free feature under Grow Your Store.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan self-assigned this Dec 12, 2022
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 12, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 66e1343

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests187006019316m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan marked this pull request as ready for review December 12, 2022 09:51
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow December 12, 2022 09:53
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chihsuan
Copy link
Member Author

One reviewer should be sufficient.

@chihsuan chihsuan merged commit 5786da4 into trunk Dec 14, 2022
@chihsuan chihsuan deleted the update/disable-tiktok-in-obw branch December 14, 2022 07:40
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 14, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
* Disable TikTok in the OBW

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants