New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup product task experiment #35950
Conversation
e7cd396
to
870c2be
Compare
Test Results SummaryCommit SHA: f332108
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up! There's a little more .. stuff .. that can be removed: f637dd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing an extensive clean up, @chihsuan! I was contemplating to keep some of the codes in WooOnboardingTask
in case if we need to experiment another task in the future, but then it wasn't the most optimal solution either with polling. Perhaps we could figure out a better way to implement in the future.
I also tested tracks and importing sample products, LGTM! 🚢 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thank you!
* Cleanup product task experiment * Rename experimental-products -> products * Add changelog * Clean up product task experiment in woo/onboarding Remove product variant * Rename experimental-import-products -> import-products * Clean up OnboardingTasks.php * Add changelog * Remove experimental-products-task feature flag
All Submissions:
Changes proposed in this Pull Request:
Closes https://github.com/woocommerce/team-ghidorah/issues/131.
How to test the changes in this Pull Request:
import product
add product stacked layout
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: