Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pinterest Extension to Onboarding Wizard #36003

Merged
merged 5 commits into from Dec 15, 2022
Merged

Add Pinterest Extension to Onboarding Wizard #36003

merged 5 commits into from Dec 15, 2022

Conversation

adrianduffell
Copy link
Contributor

@adrianduffell adrianduffell commented Dec 15, 2022 •
edited

All Submissions:

Changes proposed in this Pull Request:

Closes (partially) #34302.

Adds Pinterest for WooCommerce to the Onboarding Wizard.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

With a new site,

  1. Skip the Onboarding Wizard.
  2. Disable "Display suggestions within WooCommerce " in Settings > Advanced > WooCommerce.com.
  3. Navigate to the Free Features section in the Onboarding Wizard.
  4. See that Pinterest is listed.
  5. Select Pinterest and complete the Onboarding Wizard.
  6. On the WordPress Plugins page, confirm that Pinterest for WooCommerce plugin is installed.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@adrianduffell
Add pinterest to OBW
cd14fee 
# Conflicts:
#	plugins/woocommerce/src/Internal/Admin/RemoteFreeExtensions/DefaultFreeExtensions.php
@adrianduffell
Switch the alt data
7b65c60
@adrianduffell
Add changelog
f6b0a7b
@adrianduffell
Merge branch 'trunk' into update/obw-pinterest
e90e33e 
# Conflicts:
#	plugins/woocommerce/src/Internal/Admin/RemoteFreeExtensions/DefaultFreeExtensions.php
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 15, 2022
@adrianduffell adrianduffell requested review from a team, chihsuan and moon0326 December 15, 2022 08:12
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022 •
edited

Test Results Summary

Commit SHA: 98823ad

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 12s
E2E Tests187006019315m 10s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adrianduffell! Tested well and LGTM. 👍

@adrianduffell adrianduffell merged commit 4ccf356 into trunk Dec 15, 2022
@adrianduffell adrianduffell deleted the update/obw-pinterest branch December 15, 2022 12:02
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 15, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
@adrianduffell @samueljseay
Add Pinterest Extension to Onboarding Wizard (#36003)
6935291 
* Add pinterest to OBW

# Conflicts:
#	plugins/woocommerce/src/Internal/Admin/RemoteFreeExtensions/DefaultFreeExtensions.php

* Switch the alt data

* Add changelog

* Update copy
@ilyasfoo ilyasfoo mentioned this pull request Dec 23, 2022
Merged
8 tasks
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chihsuan chihsuan chihsuan approved these changes

@moon0326 moon0326 Awaiting requested review from moon0326 moon0326 was automatically assigned from woocommerce/ghidorah

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianduffell @chihsuan