Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coupon code label accessible #36247

Merged
merged 2 commits into from Jan 4, 2023

Conversation

IanDelMar
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Currently the coupon code label in the cart template is hidden by display: none. The label is removed from the visual flow of the page and is ignored by screen readers. To make the label accessible this PR removes the display: none and adds the screen-reader-text class to hide the label.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Jan 1, 2023
@woocommercebot woocommercebot requested review from a team and barryhughes and removed request for a team January 1, 2023 11:46
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

Let's wait on the suite of automated checks passing, then we can move ahead and merge.

@barryhughes
Copy link
Member

Re-running a couple of failed checks (probably flaky tests).

@barryhughes barryhughes merged commit e0b8294 into woocommerce:trunk Jan 4, 2023
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 4, 2023
vedanshujain pushed a commit that referenced this pull request Jan 4, 2023
* Make coupon code label accessible

* Changelog, version tag bump.

Co-authored-by: barryhughes <3594411+barryhughes@users.noreply.github.com>
@IanDelMar IanDelMar deleted the fix/coupon-code-a11y branch January 4, 2023 13:46
joelclimbsthings pushed a commit that referenced this pull request Jan 6, 2023
* Make coupon code label accessible

* Changelog, version tag bump.

Co-authored-by: barryhughes <3594411+barryhughes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants