Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode HTML entities in CategoryFieldItem #36367

Merged
merged 2 commits into from Jan 12, 2023

Conversation

mattsherman
Copy link
Contributor

@mattsherman mattsherman commented Jan 10, 2023

All Submissions:

Changes proposed in this Pull Request:

This PR decode HTML entities in category names in the CategoryFieldItem component used in the new product management experience in the categories dropdown.

Before:

Screenshot 2023-01-10 at 16 01 42

After:

Screenshot 2023-01-10 at 15 48 20

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Create a category with an ampersand (&) in the name.
  2. Navigate to the new product management experience (Products > Add New (MVP)).
  3. Verify that the Categories dropdown shows the category name correctly, with the ampersand HTML entity (&) decoded.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mattsherman mattsherman added type: bug The issue is a confirmed bug. focus: product Issues related to product or product page. focus: product management Related to product creation and editing. focus: new product ux revamped product management experience focus: product management components labels Jan 10, 2023
@mattsherman mattsherman requested a review from a team January 10, 2023 21:15
@mattsherman mattsherman self-assigned this Jan 10, 2023
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jan 10, 2023
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 4126c0d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 1s
E2E Tests189006019514m 46s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review January 10, 2023 21:47
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Nicely done @mattsherman

@mattsherman mattsherman merged commit 54c0acf into trunk Jan 12, 2023
@mattsherman mattsherman deleted the fix/categories-dropdown-decode-html-entities branch January 12, 2023 15:21
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 12, 2023
louwie17 pushed a commit that referenced this pull request Jan 13, 2023
* Decode HTML entities in CategoryFieldItem.

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing. focus: product Issues related to product or product page. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants