Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hightlighter to the tree control #36480

Merged
merged 11 commits into from Mar 1, 2023

Conversation

mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Jan 17, 2023

Depends on #36590

All Submissions:

Changes proposed in this Pull Request:

Depends on #36435
Partialy closes #35851

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Run storybook
  2. Visit http://localhost:6007/?path=/story/woocommerce-admin-experimental-treecontrol--highlight-first-matching-item
  3. After typing the first matching item should be highlighted

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mdperez86 mdperez86 added focus: product management Related to product creation and editing. focus: new product ux revamped product management experience labels Jan 17, 2023
@mdperez86 mdperez86 requested a review from a team January 17, 2023 18:44
@mdperez86 mdperez86 self-assigned this Jan 17, 2023
@github-actions github-actions bot added the package: @woocommerce/components issues related to @woocommerce/components label Jan 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023

Test Results Summary

Commit SHA: ded2caf

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests189006019516m 18s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman assigned mattsherman and unassigned mdperez86 Jan 19, 2023
@mattsherman mattsherman mentioned this pull request Jan 24, 2023
7 tasks
@mattsherman mattsherman added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jan 24, 2023
@mattsherman mattsherman marked this pull request as draft February 1, 2023 19:58
@mattsherman mattsherman removed their assignment Feb 15, 2023
@AnnaMag AnnaMag marked this pull request as ready for review February 23, 2023 14:54
@octaedro octaedro changed the base branch from trunk to add/35851-tree-control-custom-label February 24, 2023 18:55
@octaedro octaedro changed the base branch from add/35851-tree-control-custom-label to trunk February 24, 2023 18:55
@mdperez86 mdperez86 force-pushed the add-35851-tree-control-highlight-item branch from b8ae2c7 to e7b2f12 Compare February 28, 2023 18:49
@mdperez86 mdperez86 force-pushed the add-35851-tree-control-highlight-item branch from e7b2f12 to d557e7c Compare February 28, 2023 19:02
@mdperez86 mdperez86 self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #36480 (ded2caf) into trunk (ac47d18) will decrease coverage by 0.0%.
The diff coverage is 38.5%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #36480     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
- Complexity   17183    17188      +5     
==========================================
  Files          429      429             
  Lines        64799    64820     +21     
==========================================
  Hits         30251    30251             
- Misses       34548    34569     +21     
Impacted Files Coverage Δ
...mmerce/includes/admin/class-wc-admin-importers.php 0.0% <0.0%> (ø)
plugins/woocommerce/includes/class-wc-ajax.php 4.3% <0.0%> (-0.1%) ⬇️
...s/Version1/class-wc-rest-coupons-v1-controller.php 42.9% <0.0%> (ø)
...rs/Version1/class-wc-rest-orders-v1-controller.php 46.2% <0.0%> (ø)
...rters/class-wc-product-csv-importer-controller.php 36.1% <28.6%> (ø)
.../includes/import/class-wc-product-csv-importer.php 74.9% <44.4%> (ø)
...s/Version2/class-wc-rest-coupons-v2-controller.php 94.7% <75.0%> (ø)
plugins/woocommerce/includes/class-wc-coupon.php 73.9% <100.0%> (ø)
...lugins/woocommerce/includes/class-wc-discounts.php 84.5% <100.0%> (ø)
...e/includes/import/abstract-wc-product-importer.php 63.7% <100.0%> (ø)
... and 18 more

@nathanss nathanss self-requested a review March 1, 2023 14:20
Significance: minor
Type: dev

Add hightlighter to the tree control
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here! highlighter instead of hightlighter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh! Nice catch. Thanks!

@@ -39,6 +39,21 @@ type BaseTreeProps = {
* @param value The unselection
*/
onRemove?( value: Item | Item[] ): void;
/**
* It gives a way to determine whether the current rendering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think provides instead of gives is more appropriate here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nathanss
Copy link
Contributor

nathanss commented Mar 1, 2023

I tested the storybook and it's working as expected! Nice job! Just left a few comments.

@mdperez86 mdperez86 requested a review from nathanss March 1, 2023 15:53
@mdperez86 mdperez86 merged commit e612114 into trunk Mar 1, 2023
@mdperez86 mdperez86 deleted the add-35851-tree-control-highlight-item branch March 1, 2023 16:52
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing. package: @woocommerce/components issues related to @woocommerce/components status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Allow users to add items using keyboard
3 participants