New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hightlighter to the tree control #36480
Conversation
Test Results SummaryCommit SHA: ded2caf
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
b8ae2c7
to
e7b2f12
Compare
e7b2f12
to
d557e7c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #36480 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
- Complexity 17183 17188 +5
==========================================
Files 429 429
Lines 64799 64820 +21
==========================================
Hits 30251 30251
- Misses 34548 34569 +21
|
Significance: minor | ||
Type: dev | ||
|
||
Add hightlighter to the tree control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here! highlighter
instead of hightlighter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh! Nice catch. Thanks!
@@ -39,6 +39,21 @@ type BaseTreeProps = { | |||
* @param value The unselection | |||
*/ | |||
onRemove?( value: Item | Item[] ): void; | |||
/** | |||
* It gives a way to determine whether the current rendering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think provides
instead of gives
is more appropriate here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I tested the storybook and it's working as expected! Nice job! Just left a few comments. |
Depends on #36590
All Submissions:
Changes proposed in this Pull Request:
Depends on #36435
Partialy closes #35851
How to test the changes in this Pull Request:
http://localhost:6007/?path=/story/woocommerce-admin-experimental-treecontrol--highlight-first-matching-item
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: