New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows developers to add their own filters to the active filters list #36705
Conversation
@webdados Sorry for the delay in reviewing. Thanks for submitting this. This looks okay except it is missing doc blocks on the hooks and doesn't have a changelog entry. You can add the changelog entry with
|
Sorry, not sure what you mean by "missing doc blocks on the hooks". |
I meant PHPDocs. An example. We follow the WordPress docs standard for this.
No, but if you have |
@webdados If you add the docblocs on the hooks, I'll add the changelog entry. |
Add params and docblocks to the new proposed hooks woocommerce_widget_layered_nav_filters_start and woocommerce_widget_layered_nav_filters_end
I've added the changelog. Could you add them for |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the changelog to the correct folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webdados Thanks for your patience with this.
Fixes #36704
All Submissions:
Changes proposed in this Pull Request:
Closes #36704 allowing developers to add their own custom filters to the active filters widget
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: