Fix create wc extension script #36917

louwie17 · 2023-02-22T11:46:10Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Updates the create-wc-extension script within the woocommerce-admin plugin to run the create-extension from the root package instead.

Closes #36890 .

This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Have you followed the Writing high-quality testing instructions guide?

cd plugins/woocommerce-admin
npm run create-wc-extension
This should run correctly ( this will generate a plugin folder as a sibling to the woocommerce-monorepo folder instead of the woocommerce-admin folder.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

codecov · 2023-02-22T12:15:35Z

Codecov Report

Merging #36917 (31bcf3f) into trunk (f9f6e68) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 31bcf3f differs from pull request most recent head eda2798. Consider uploading reports for the commit eda2798 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             trunk   #36917     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
+ Complexity   17178    17171      -7     
==========================================
  Files          429      429             
  Lines        64779    64762     -17     
==========================================
- Hits         30240    30222     -18     
- Misses       34539    34540      +1

Impacted Files	Coverage Δ
...ns/woocommerce/includes/class-wc-order-factory.php	`75.2% <0.0%> (-4.2%)`	⬇️
...oocommerce/includes/abstracts/abstract-wc-data.php	`91.8% <0.0%> (-0.4%)`	⬇️
...ocommerce/includes/abstracts/abstract-wc-order.php	`86.9% <0.0%> (-<0.1%)`	⬇️
...ommerce/includes/admin/class-wc-admin-settings.php	`16.8% <0.0%> (+<0.1%)`	⬆️
plugins/woocommerce/includes/class-wc-tax.php	`79.0% <0.0%> (+0.5%)`	⬆️
...ins/woocommerce/includes/class-wc-cache-helper.php	`31.0% <0.0%> (+4.4%)`	⬆️

github-actions · 2023-02-22T12:19:35Z

Test Results Summary

Commit SHA: eda2798

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 0s
E2E Tests	189	0	0	6	0	195	14m 58s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

samueljseay

Tests well for me. Thanks for this!

* Add an encoding selector to the product importer * Add changelog file * Don't assume the character encoding parameter is present * Add woocommerce_attributes_saved trigger. Closes #35004. * Fix create wc extension script (#36917) * Run create-extension for create-wc-extension script * Add changelog --------- Co-authored-by: Sam Seay <samueljseay@gmail.com> * Update product editor package (#36830) * Add missing dev packages to product-editor package * Create components folder for organization * Move product field, section and tab slots over to product-editor package * Move use of product slot fills to product-editor package * Sync dependencies * Add changelogs * Update README's and add constant for default values * Update README's in product-editor package * Change SORT_STRING to SORT_NATURAL for the encodings list Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com> * Add changelog * Add custom rendering logic to the item label (#36476) * Add type definitions * Add custom rendering logic to the item label * Add stories * Add changelog file * Fix rebase merge issue * Fix up stories after rebase --------- Co-authored-by: Matt Sherman <matt@jam123.com> * Fix k6 incorrect step * Fix k6 test env setup --------- Co-authored-by: Nestor Soriano <konamiman@konamiman.com> Co-authored-by: helgatheviking <507025+helgatheviking@users.noreply.github.com> Co-authored-by: louwie17 <lourensschep@gmail.com> Co-authored-by: Sam Seay <samueljseay@gmail.com> Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com> Co-authored-by: Maikel David Pérez Gómez <mdperez86@gmail.com> Co-authored-by: Matt Sherman <matt@jam123.com>

* Add an encoding selector to the product importer * Add changelog file * Don't assume the character encoding parameter is present * Add woocommerce_attributes_saved trigger. Closes #35004. * Fix create wc extension script (#36917) * Run create-extension for create-wc-extension script * Add changelog --------- Co-authored-by: Sam Seay <samueljseay@gmail.com> * Update product editor package (#36830) * Add missing dev packages to product-editor package * Create components folder for organization * Move product field, section and tab slots over to product-editor package * Move use of product slot fills to product-editor package * Sync dependencies * Add changelogs * Update README's and add constant for default values * Update README's in product-editor package * Change SORT_STRING to SORT_NATURAL for the encodings list Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com> * Add changelog * Add custom rendering logic to the item label (#36476) * Add type definitions * Add custom rendering logic to the item label * Add stories * Add changelog file * Fix rebase merge issue * Fix up stories after rebase --------- Co-authored-by: Matt Sherman <matt@jam123.com> * Enable "Smoke test release" workflow (#36598) * First pass at updating release test workflow * Add changelog * Set dir env variables * Update to workflow * Fix indent * Fix indent * Clean up indent * Re-order steps * Change order of jobs * Added common php versions * Update pipeline * Update some labels * Simplify for testing * Update paths * Create tmp folder * Fix path * Paths * Try outputting some debugging * Add step ID back * Remove working directory * Another path tweak * Add API release tests * Add k6 tests * Add PHP tests * Launch wp-env during PHP tests * Try default values * Tweak some settings, add WP testing * Tweak some settings * Re-order e2e steps * Update step descriptions * Reorganize tests, add plugin tests * Enable only e2e job * Initial set up to run against release smoke test site * Fix syntax * Temporarily disable update wc spec * Temporarily disable downloading woocommerce zip * Download release zip using tag name * Fix wrong job name * Fix wrong job name * Fix dir * Delete fetch-asset-id.js * REfactor update-woocommerce spec * Add error handling * Download release zip by tag * Refactor update woo spec to download zip by tag * Correct job name * fail test on invalid tag * Enable all e2e tests * Run api tests before e2e tests * Fix job dependency * Add customer credentials to api job * Separate job for WC Update * Combine e2e allure-results, then report * Enable report job * Fix context * Change job and artifact names * Use test s3 path * Minor job name change * Upload artifacts to bucket * Correct s3 path * Add quiet option * Retain video on failures * Finalize s3 path * Try WP latest-1 * Revert to wp latest * Refine search for woocommerce zip asset * Get created-at * Specify repo in gh command * Slugify env description * Trim space * Sync with bucket instead of copy * Remove invalid --recursive flag * Re-add missing step to combine e2e results from update wc test * Ensure artifact upload on test failure * Enable all e2e tests on WP latest * Retain existing data before updating WC * Make test compatible with 'Canceled' and 'Cancelled' * Set env_desc as env var * Re-add deleted file * Fix UPDATE_WC in daily smoke test workflow * Add tracing in global setup * Remove tracing * Temporarily run only basic spec * Job for WP Latest-1 & 2 * Fix "Required input 'created_at' not provided" * Minor rename * Remove install filter * Install deps in get-wp-matrix * Delete get-wp-versions.js * Add get-wp-versions.js to e2e-pw folder * REname file * REfactor * Refactor script for getting WP prev versions * Update job dependencies * Temporarily remove disabled jobs * Allow e2e-wp-latest after api test failure * Update L-1 & L-2 job deps * Fix report-wp-latest * Fix failing api test * Make get-wp-versions quicker * Publish report immediately after test * Test reporting in e2e-update-wc * Fix missing parameter * Fix env_desc, re-enable other jobs * Enable all e2e tests * Minor job name change * Fix flaky test * Add php version testing * stringify php versions * Re-enable all e2e tests * Up timeout to 2min * Remove PHP 8.0 * Add missing conditionals * Fix php version verification script * Fix starting dir * Fix flakiness * Skip e2e if api failed * Verify woocommerce.zip early * Add token * Delete test summary on github for the meantime * Use default playwright config * More meaningful variable names * Update step titles based on review * Use expect.poll() * Minor spacing corrections * Use `stable-check` endpoint, delete unnecessary loop * Update locators to be JN-compatible * Fix erroneous getting of release tag * Fix conflict of "No thanks" button locator with that of WP Mail Logging's * Update github-script action to v6 * Revert to 'Cancelled' * Remove unnecessary step * Provide missing env variables --------- Co-authored-by: Jon Lane <jon.lane@automattic.com> Co-authored-by: Jonathan Lane <lanej0@users.noreply.github.com> * Rename workflow file --------- Co-authored-by: Nestor Soriano <konamiman@konamiman.com> Co-authored-by: helgatheviking <507025+helgatheviking@users.noreply.github.com> Co-authored-by: louwie17 <lourensschep@gmail.com> Co-authored-by: Sam Seay <samueljseay@gmail.com> Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com> Co-authored-by: Maikel David Pérez Gómez <mdperez86@gmail.com> Co-authored-by: Matt Sherman <matt@jam123.com> Co-authored-by: Jon Lane <jon.lane@automattic.com> Co-authored-by: Jonathan Lane <lanej0@users.noreply.github.com>

* Run create-extension for create-wc-extension script * Add changelog --------- Co-authored-by: Sam Seay <samueljseay@gmail.com>

louwie17 added 2 commits February 22, 2023 12:40

Run create-extension for create-wc-extension script

55e5762

Add changelog

31bcf3f

louwie17 requested a review from samueljseay February 22, 2023 11:46

github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Feb 22, 2023

louwie17 mentioned this pull request Feb 22, 2023

Error using create-wc-extension command. #36890

Closed

5 tasks

louwie17 self-assigned this Feb 23, 2023

Merge branch 'trunk' into fix/36890_create_wc_extension_script

eda2798

samueljseay approved these changes Feb 24, 2023

View reviewed changes

louwie17 merged commit 2ef4f8a into trunk Feb 24, 2023

louwie17 deleted the fix/36890_create_wc_extension_script branch February 24, 2023 08:28

github-actions bot added this to the 7.6.0 milestone Feb 24, 2023

samueljseay added a commit that referenced this pull request Feb 28, 2023

Fix create wc extension script (#36917)

b39e4a3

* Run create-extension for create-wc-extension script * Add changelog --------- Co-authored-by: Sam Seay <samueljseay@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix create wc extension script #36917

Fix create wc extension script #36917

louwie17 commented Feb 22, 2023

codecov bot commented Feb 22, 2023 •

edited

github-actions bot commented Feb 22, 2023 •

edited

samueljseay left a comment

Fix create wc extension script #36917

Fix create wc extension script #36917

Conversation

louwie17 commented Feb 22, 2023

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

codecov bot commented Feb 22, 2023 • edited

Codecov Report

github-actions bot commented Feb 22, 2023 • edited

Test Results Summary

samueljseay left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 22, 2023 •

edited

github-actions bot commented Feb 22, 2023 •

edited