Turn WC_Order::get_tax_location public

[senadir]

This PR turns the get_tax_location function public, this is needed so plugins like Avatax can get the tax location to recalculate taxes (for subscriptions for example). An alternative would be to duplicate the function.

How to test the changes in this Pull Request:

This is a safe backward compatible change

1. Go to an on hold order in WooCommerce admin.
2. Change an item price.
3. Recalculate totals, it should work fine.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
• Have you included testing instructions?

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[codecov]

Codecov Report

Merging #36953 (5d25edd) into trunk (6f8f35b) will increase coverage by 0.0%.
The diff coverage is 71.4%.

Additional details and impacted files

@@           Coverage Diff            @@
##             trunk   #36953   +/-   ##
========================================
  Coverage     46.7%    46.7%           
  Complexity   17188    17188           
========================================
  Files          429      429           
  Lines        64821    64826    +5     
========================================
+ Hits         30251    30254    +3     
- Misses       34570    34572    +2     

Impacted Files	Coverage Δ
...ocommerce/includes/abstracts/abstract-wc-order.php	86.7% <0.0%> (-0.2%)	⬇️
.../includes/import/class-wc-product-csv-importer.php	75.1% <100.0%> (+0.2%)	⬆️

[github-actions]

Test Results Summary

Commit SHA: 5d25edd

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 16s
E2E Tests	189	0	0	6	0	195	14m 57s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[jonathansadowski]

I have some concerns that there will always be versions of WooCommerce where this method isn't public, and simply changing it to public would encourage non-defensive coding, and perhaps lead to future errors here.

What do you think about having a simple public wrapper method that calls the protected method?

[wavvves]

I have some concerns that there will always be versions of WooCommerce where this method isn't public, and simply changing it to public would encourage non-defensive coding, and perhaps lead to future errors here.

What do you think about having a simple public wrapper method that calls the protected method?

Agree, I've made some changes to accommodate for this.

[jonathansadowski]

👍 thanks for updating