Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking support for marketplace and multichannel marketing options. #37017

Merged
merged 1 commit into from Mar 8, 2023

Conversation

layoutd
Copy link
Contributor

@layoutd layoutd commented Mar 1, 2023

Track if Marketplace suggestions and the new WooCommerce Multichannel Marketing experience are enabled (pbIy4N-3hL-p2):

In WooCommerce > Settings > Advanced > WooCommerce.com
image

In WooCommerce > Settings > Advanced > Features
image

All Submissions:

How to test the changes in this Pull Request:

Using WP CLI, try running:

wp eval "print_r( WC_Tracker::get_tracking_data()['settings'] );"

At the end of the output, you should see the new Marketplace suggestions and MCM-related options, looking something like this:

    [show_marketplace_suggestions] => yes
    [multichannel_marketing_enabled] => no

Each option should have the value yes if the corresponding option in WC settings is enabled, or no or an empty value if the corresponding option in WC settings is not enabled.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@layoutd layoutd self-assigned this Mar 1, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Test Results Summary

Commit SHA: f0c2df5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests189006019513m 27s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@layoutd layoutd requested a review from a team March 1, 2023 17:18
Copy link
Contributor

@ibndawood ibndawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @layoutd, for the changes. I've followed the test instructions, and the changes test well.

@layoutd layoutd requested review from a team and jorgeatorres and removed request for a team March 3, 2023 05:56
@layoutd
Copy link
Contributor Author

layoutd commented Mar 8, 2023

Hi @jorgeatorres, this is a tiny PR, would you mind taking a look and giving it a green light if it's ready, so I can update the project to completed? (But not shipped until WC 7.6 in mid-April).
Thanks! 🙇🏻

Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@layoutd layoutd merged commit a74f80d into trunk Mar 8, 2023
@layoutd layoutd deleted the add/marketing-trackers branch March 8, 2023 14:41
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants