Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rest namespace for product post type to v3 #37028

Merged
merged 2 commits into from Mar 3, 2023

Conversation

joelclimbsthings
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes #36990 .

How to test the changes in this Pull Request:

  1. Checkout branch.
  2. Open the network tab in your browser dev tools.
  3. Either get the productId of an existing product, or create a new one.
  4. In the console, run window.wp.data.select( 'core' ).getEditedEntityRecord( 'postType', 'product', PRODUCT_ID ) with that product ID in place of PRODUCT_ID.
  5. Observe that the resulting API request uses the v3 namespace:
    image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@joelclimbsthings joelclimbsthings changed the title Declaring rest namespace for product post type as v3 Updating rest namespace for product post type to v3 Mar 2, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 2, 2023
@joelclimbsthings joelclimbsthings self-assigned this Mar 2, 2023
@joelclimbsthings joelclimbsthings requested a review from a team March 2, 2023 00:38
@joelclimbsthings joelclimbsthings marked this pull request as ready for review March 2, 2023 00:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Test Results Summary

Commit SHA: 7da4fae

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests189006019513m 42s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that v3 of the endpoint is used.

@joelclimbsthings joelclimbsthings merged commit 36655cb into trunk Mar 3, 2023
@joelclimbsthings joelclimbsthings deleted the update/entity-store-endpoint-36990 branch March 3, 2023 16:30
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update entity store config for products to use v3 endpoint
2 participants