Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to enable Save attributes and Save variations buttons #37046

Merged
merged 13 commits into from Mar 9, 2023
Merged

Add validation to enable Save attributes and Save variations buttons #37046

merged 13 commits into from Mar 9, 2023

Commits on Mar 8, 2023

  1. Add validation for attributes and variations

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2f5f889 View commit details
    Browse the repository at this point in the history

  2. Enable save button when data is valid 

    # Conflicts:
#	plugins/woocommerce/includes/admin/meta-boxes/views/html-product-data-variations.php
    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d6b4404 View commit details
    Browse the repository at this point in the history

  3. Add changelog

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    738e16f View commit details
    Browse the repository at this point in the history

  4. Remove if

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    89f3e30 View commit details
    Browse the repository at this point in the history

  5. Remove validation while saving 

    # Conflicts:
#	plugins/woocommerce/client/legacy/js/admin/meta-boxes-product-variation.js
    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b485c1d View commit details
    Browse the repository at this point in the history

  6. Rename method is_attribute_or_variation_empty

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    03dcdc6 View commit details
    Browse the repository at this point in the history

  7. Add button title when disabled 

    # Conflicts:
#	plugins/woocommerce/includes/admin/meta-boxes/views/html-product-data-variations.php
    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    da8b2eb View commit details
    Browse the repository at this point in the history

  8. Fix typo

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8cbbcb0 View commit details
    Browse the repository at this point in the history

  9. Fix e2e tests

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    adea6ec View commit details
    Browse the repository at this point in the history

  10. Convert functions into global fn

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    816aa12 View commit details
    Browse the repository at this point in the history

  11. Use maybe_disable_save_button

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    932745d View commit details
    Browse the repository at this point in the history

  12. Fix validation

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0d131d6 View commit details
    Browse the repository at this point in the history

  13. Refactor is_attribute_or_variation_empty

    Fernando Marichal committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7475492 View commit details
    Browse the repository at this point in the history