New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reference to WC_API_Server #37054
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #37054 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
Complexity 17188 17188
==========================================
Files 429 429
Lines 64820 64821 +1
==========================================
Hits 30251 30251
- Misses 34569 34570 +1 |
@chihsuan Changelog added 🍏 |
Thanks @szepeviktor. I'll let @Konamiman review this PR. 🙏 |
Upper/lowercase changes only! |
Hi @szepeviktor, thanks for your contribution. Could you please add some testing instructions to the pull request description? |
Okay. |
@szepeviktor Thanks but I meant testing instructions for WooCommerce itself. Is there some action that can be performed on a WooCommerce install, that fails without this fix but works once the fix is put in place? |
@Konamiman No. PHP is a lenient language. |
Pull request was closed
All Submissions:
Changes proposed in this Pull Request:
Was spelled "WC_API_SERVER"
From #37015 (comment)
Testing instructions
Please set up PHPStan. @phpstan discovered this problem.
Here is how #37015 (comment)