Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to WC_API_Server #37054

Merged
merged 2 commits into from Feb 15, 2024
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Mar 3, 2023

All Submissions:

Changes proposed in this Pull Request:

Was spelled "WC_API_SERVER"
From #37015 (comment)

Testing instructions

Please set up PHPStan. @phpstan discovered this problem.
Here is how #37015 (comment)

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Mar 3, 2023
@woocommercebot woocommercebot requested review from a team and Konamiman and removed request for a team March 3, 2023 13:40
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (987b4fe) 46.7% compared to head (96a5a79) 46.7%.
Report is 12353 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37054     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17188    17188             
==========================================
  Files          429      429             
  Lines        64820    64821      +1     
==========================================
  Hits         30251    30251             
- Misses       34569    34570      +1     

see 1 file with indirect coverage changes

@szepeviktor
Copy link
Contributor Author

@chihsuan Changelog added 🍏

@chihsuan
Copy link
Member

chihsuan commented Mar 6, 2023

Thanks @szepeviktor. I'll let @Konamiman review this PR. 🙏

@szepeviktor
Copy link
Contributor Author

Upper/lowercase changes only!

@Konamiman
Copy link
Contributor

Hi @szepeviktor, thanks for your contribution. Could you please add some testing instructions to the pull request description?

@szepeviktor
Copy link
Contributor Author

Okay.

@Konamiman
Copy link
Contributor

@szepeviktor Thanks but I meant testing instructions for WooCommerce itself. Is there some action that can be performed on a WooCommerce install, that fails without this fix but works once the fix is put in place?

@szepeviktor
Copy link
Contributor Author

Is there some action that can be performed on a WooCommerce install, that fails without this fix but works once the fix is put in place?

@Konamiman No. PHP is a lenient language.

@chihsuan chihsuan enabled auto-merge (squash) February 15, 2024 06:57
@chihsuan chihsuan closed this Feb 15, 2024
auto-merge was automatically disabled February 15, 2024 06:57

Pull request was closed

@chihsuan chihsuan reopened this Feb 15, 2024
@chihsuan chihsuan enabled auto-merge (squash) February 15, 2024 06:57
@chihsuan chihsuan merged commit 49557b3 into woocommerce:trunk Feb 15, 2024
52 of 58 checks passed
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 15, 2024
@szepeviktor szepeviktor deleted the fix/class-name branch February 15, 2024 07:23
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants