Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class namespaces in Onboarding #37056

Merged
merged 2 commits into from Mar 6, 2023
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Mar 3, 2023

All Submissions:

Changes proposed in this Pull Request:

\Onboarding was missing from those namespaces.
From #37015 (comment)

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: react admin type: community contribution labels Mar 3, 2023
@woocommercebot woocommercebot requested review from a team, coreymckrill, chihsuan and moon0326 and removed request for a team March 3, 2023 14:00
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #37056 (447f83c) into trunk (7ec2ad6) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 447f83c differs from pull request most recent head 5c7f8fe. Consider uploading reports for the commit 5c7f8fe to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37056     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17188    17188             
==========================================
  Files          429      429             
  Lines        64820    64820             
==========================================
- Hits         30252    30251      -1     
- Misses       34568    34569      +1     
Impacted Files Coverage Δ
plugins/woocommerce/includes/class-wc-tax.php 78.6% <0.0%> (-0.2%) ⬇️

@chihsuan
Copy link
Member

chihsuan commented Mar 6, 2023

Hey @szepeviktor Thanks for the fix! Could you please add a changelog via pnpm --filter=woocommerce changelog add?

@szepeviktor
Copy link
Contributor Author

@chihsuan Changelog added 🍏

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it quickly!

@chihsuan chihsuan merged commit 50fe847 into woocommerce:trunk Mar 6, 2023
17 of 18 checks passed
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 6, 2023
@szepeviktor szepeviktor deleted the patch-3 branch March 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants