Fixes react version to 17.0.2 globally #37087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
Test Results SummaryCommit SHA: 9ae16f9
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37087 +/- ##
========================================
Coverage 46.7% 46.7%
Complexity 17188 17188
========================================
Files 429 429
Lines 64821 64821
========================================
Hits 30251 30251
Misses 34570 34570 |
samueljseay
reviewed
Mar 6, 2023
| @@ -109,7 +109,7 @@ describe( 'ReviewsPanel', () => { | |||
| expect( screen.queryByText( 'Delete' ) ).toBeInTheDocument(); | |||
| } ); | |||
|
|
|||
| it( 'should trigger updateReview with status approved when Approve is clicked', () => { | |||
| it.skip( 'should trigger updateReview with status approved when Approve is clicked', () => { | |||
There was a problem hiding this comment.
How come you had to skip these tests?
There was a problem hiding this comment.
Because of a conflict between react 18 and 17. But in a peer dependency that I could not solve in an easy way. We are going to create an issue to investigate this and re-enable back these tests.
There was a problem hiding this comment.
This is the issue.
samueljseay
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes the
reactand@types/reactversions to17.0.2globally to avoid conflicting with mismatched peer dependencies.How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: