fix: mobile app connection owner bug

[rjchow]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

A bug was discovered where users who had changed their wpcom display names would be shown the "not owner of connection" modal for the mobile app feature modal.

The cause of this was the assumption that the .connectionOwner field represents the user's wpcom username, but it turns out that it actually holds the user's display name. This went unnoticed in testing as the default display name is the user's username.

How to test the changes in this Pull Request:

• Have you followed the Writing high-quality testing instructions guide?

1. Set up the WooCommerce site using Jurassic Ninja, live branch or some other setup where you can have a Jetpack connection running. To test this thoroughly, check that your wpcom account's display name != your username.
2. After going through the onboarding wizard and connecting your wordpress.com account, observe that you can see the mobile app task in the task list and in the help menu.
3. Create another user on the wordpress site and log in as that user. You should not be able to see the mobile app task or help menu entry.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
• Have you included testing instructions?

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[codecov]

Codecov Report

Merging #37170 (4127eca) into trunk (7c76118) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##             trunk   #37170   +/-   ##
========================================
  Coverage     46.7%    46.7%           
- Complexity   17188    17191    +3     
========================================
  Files          429      429           
  Lines        64820    64845   +25     
========================================
+ Hits         30253    30276   +23     
- Misses       34567    34569    +2     

see 13 files with indirect coverage changes

[github-actions]

Test Results Summary

Commit SHA: 4127eca

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 7s
E2E Tests	189	0	0	6	0	195	17m 41s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[chihsuan]

Thanks for fixing it! Looks good and worked as described. 👍

[adrianduffell]

LGTM, nice catch @rjchow ! 🚀