Specify args for wp.data resolution in marketing page to support WP 5.9 #37198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #37176.
In this PR, we specify empty array
[]
as the second argument for calls toinvalidateResolution
in marketing page to make it work with WordPress 5.9.To make things consistent, we also specify empty array
[]
as the second argument for calls tohasFinishedResolution
.How to test the changes in this Pull Request:
Functionality test:
Pre-conditions:
/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=features
/wp-admin/admin.php?page=wc-admin&path=%2Fmarketing
Code check
invalidateResolution
under theplugins/woocommerce-admin/client/marketing
folder. Make sure all the calls to the function has the second argument specified.hasFinishedResolution
under theplugins/woocommerce-admin/client/marketing
folder. Make sure all the calls to the function has the second argument specified.Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: