New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual tweaks for shipping task partners #37229
Visual tweaks for shipping task partners #37229
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37229 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
- Complexity 17191 17192 +1
==========================================
Files 429 429
Lines 64845 64872 +27
==========================================
+ Hits 30275 30282 +7
- Misses 34570 34590 +20
|
Test Results SummaryCommit SHA: f484ceb
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @moon0326 Thanks fort tweaking this. I wasn't able to see the dual layout when choosing Denmark
as my store country so I used UK
instead.
And I'm not sure if it's my local env issue. I don't see any difference in the single shipping partner layout. 🤔
BTW, It seem that the linting is failing.
@verofasulo Do you think it would be better to align the buttons to the bottom? |
@chihsuan, thanks for tagging me 💜 And yes, totally! 🙏 |
Thank you for the catch 🙏 I might have committed a different change. Updated in 459e4c8 |
Updated in 981f867 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing this 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good and tested well. 👍
All Submissions:
Changes proposed in this Pull Request:
This PR tweaks shipping task partner CSS. For more details, please see #36977
Closes #36977 .
How to test the changes in this Pull Request:
return true
from here to force Shipping Task.Denmark
as your store country to force the dual shipping partner layout.WooCommerce -> Home
and clickAdd shipping costs
task.WooCommerce -> Home
and clickAdd shipping costs
task.Before
After (More spacing between the image and list)
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: