Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Customers report with latest user data after editing user #37237

Merged
merged 2 commits into from Mar 15, 2023

Conversation

mattsherman
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR updates the Customers report (specifically, the lookup tables it uses) with the latest user data when a user is edited. Previously, the Customers report was updated with the previous user data (see bug #37235).

Closes #37235.

How to test the changes in this Pull Request:

  1. Make a change to the last name of a customer user profile at Users (/wp-admin/users.php)
  2. Go to the Customers report at WooCommerce > Customers
  3. Verify that the updated last name is displayed.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@mattsherman mattsherman self-assigned this Mar 15, 2023
@mattsherman mattsherman requested a review from a team March 15, 2023 14:06
@mattsherman mattsherman added the type: bug The issue is a confirmed bug. label Mar 15, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 15, 2023
@mattsherman mattsherman marked this pull request as ready for review March 15, 2023 14:06
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #37237 (c23d07c) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 32.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37237     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17191    17191             
==========================================
  Files          429      429             
  Lines        64845    64865     +20     
==========================================
+ Hits         30275    30282      +7     
- Misses       34570    34583     +13     
Impacted Files Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️
...gins/woocommerce/includes/wc-product-functions.php 44.7% <100.0%> (+1.0%) ⬆️

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: c23d07c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 48s
E2E Tests189006019517m 4s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro requested review from octaedro and removed request for a team March 15, 2023 20:21
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well here! Good job @mattsherman :shipit:

@mattsherman mattsherman merged commit fb3a920 into trunk Mar 15, 2023
30 of 32 checks passed
@mattsherman mattsherman deleted the fix/update-customer-after-user-edit branch March 15, 2023 23:11
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: analytics plugin: woocommerce Issues related to the WooCommerce Core plugin. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics: Customers report not updated with latest when user profile is edited in wp-admin
2 participants