Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playwright api-core-tests to associate orders with real products to prevent extension issues for those that validate product ids #37243

Conversation

nigeljamesstevenson
Copy link
Contributor

@nigeljamesstevenson nigeljamesstevenson commented Mar 15, 2023

All Submissions:

Changes proposed in this Pull Request:

Update playwright api-core-tests to associate orders with real products to prevent extension issues for those that validate product ids

Closes #37220.

How to test the changes in this Pull Request:

  1. Run extensions test in QIT
  2. Observe test results
  3. Tests should now pass (previously they were failing on extensions that were validating against product ids)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

…ts to prevent extension issues for those that validate product ids
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 15, 2023
@nigeljamesstevenson nigeljamesstevenson changed the title Update playwright api-core-tests to associate orders with real products… Update playwright api-core-tests to associate orders with real products to prevent extension issues for those that validate product ids Mar 15, 2023
@nigeljamesstevenson nigeljamesstevenson added the focus: api tests Issues related to API tests. label Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #37243 (d77ec6a) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 32.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37243     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
  Complexity   17191    17191             
==========================================
  Files          429      429             
  Lines        64845    64865     +20     
==========================================
+ Hits         30275    30284      +9     
- Misses       34570    34581     +11     
Impacted Files Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️
...gins/woocommerce/includes/wc-product-functions.php 44.7% <100.0%> (+1.0%) ⬆️

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: d77ec6a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 49s
E2E Tests189006019514m 42s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks so much for getting these in so quickly @nigeljamesstevenson!

Copy link
Contributor

@MrJnrman MrJnrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thanks @nigeljamesstevenson!

@lanej0 lanej0 merged commit 185cd3d into trunk Mar 20, 2023
27 of 29 checks passed
@lanej0 lanej0 deleted the update/Update-the-api-core-tests-to-associate-orders-with-real-products branch March 20, 2023 20:23
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: api tests Issues related to API tests. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the api-core-tests to associate orders with real products
4 participants