New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CES data store to @woocommerce/customer-effort-score #37252
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37252 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
- Complexity 17191 17192 +1
==========================================
Files 429 429
Lines 64845 64872 +27
==========================================
+ Hits 30275 30282 +7
- Misses 34570 34590 +20
|
Test Results SummaryCommit SHA: 6e2ed19
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Significance: minor | ||
Type: dev | ||
|
||
dd CES data store to @woocommerce/customer-effort-score |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing 'a'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Fixed in 6e2ed19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing I found this odd behavior with the snackbar in the Analytics page, where I had to scroll all the way down to see it (it wasn't showing in a fixed position). I've seen and reported it before and I think we concluded that it was not our fault. Definitely not related to this PR.
@nathanss Fixed the typo -- ready for re-review!
Hmm, haven't seen that! Do you know if we have an issue logged for it? |
I think @louwie17 looked into it. Can you remember, Lourens? |
All Submissions:
Changes proposed in this Pull Request:
This PR moves the CES data store currently found in
woocommerce/admin/client
to the@woocommerce/customer-effort-score
package. This builds on the work started in #37112.No functionality should be impacted by this change... this is just a package file refactoring.
Note: There are non-generic bits of functionality in the CES data store (controlling whether specific modals are shown, etc.)... these should be abstracted out in the future to a pattern where
@woocommerce/customer-effort-score
contains no feature-specific details. For now though, we can live with this.Closes #37247.
How to test the changes in this Pull Request:
Note: make sure tracking is enabled under WooCommerce > Settings > Advanced > WooCommerce.com
In order for CES snackbars and such to show up, you need to have not already dismissed/completed the CES for a particular feature. To reset things, you can delete the
woocommerce_ces_shown_for_actions
transient (use the WCA Test Helper).Load this branch and run
pnpm install && pnpm run build
and make sure everything builds correctly.Smoke test WCAdmin pages and make sure that any CES-related functionality works correctly.
Open your console and check if the following exist under
window.wc.customerEffortScore
(there will be more, these are the new ones added in this PR):STORE_KEY
QUEUE_OPTION_NAME
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: