Convert "Allow backorders?" into radio buttons #37282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37282 +/- ##
========================================
Coverage 45.8% 45.8%
Complexity 17196 17196
========================================
Files 429 429
Lines 64909 64911 +2
========================================
+ Hits 29701 29705 +4
+ Misses 35208 35206 -2
|
Test Results SummaryCommit SHA: 2786b10
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
octaedro
added
focus: product management
octaedro
force-pushed
the
dev/37118_convert_allow_backorders_into_radio_buttons
branch
from
4e2c8e5
to
138e36a
Compare
mattsherman
requested changes
Mar 20, 2023
| * | ||
| * @param bool If false, "Allow backorders?" will be shown as a select. Default: it will use radio buttons. | ||
| */ | ||
| if ( apply_filters( 'woocommerce_product_allow_backorder_use_radio', false ) ) { |
There was a problem hiding this comment.
The default should be true, otherwise, the radios are not used by default!
| if ( apply_filters( 'woocommerce_product_allow_backorder_use_radio', false ) ) { | ||
| woocommerce_wp_radio( $common_backorder_args ); | ||
| } else { | ||
| $select_input_args = array( | ||
| 'desc_tip' => true, |
There was a problem hiding this comment.
Same comment as on #37278... I think we should keep the tip.
added 2 commits
March 20, 2023 13:21
mattsherman
approved these changes
Mar 20, 2023
Comment on lines
+129
to
+138
| $stock_status_options = wc_get_product_stock_status_options(); | ||
| $stock_status_count = count( $stock_status_options ); | ||
| $stock_status_args = array( | ||
| 'id' => '_stock_status', | ||
| 'value' => $product_object->get_stock_status( 'edit' ), | ||
| 'wrapper_class' => 'stock_status_field hide_if_variable hide_if_external hide_if_grouped', | ||
| 'label' => __( 'Stock status', 'woocommerce' ), | ||
| 'options' => $stock_status_options, | ||
| 'desc_tip' => true, | ||
| 'description' => __( 'Controls whether or not the product is listed as "in stock" or "out of stock" on the frontend.', 'woocommerce' ), |
There was a problem hiding this comment.
These changes are not directly related to the PR. It would be good in the future to either split them out or, since this is admittedly a small change and closely related, just reference that the change was made in the PR description/comments, so it is clear to the reviewer!
octaedro
deleted the
dev/37118_convert_allow_backorders_into_radio_buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds the code to convert the "Allow backorders?" dropdown into radio buttons.
If the number of items inside exceeds three, it should be displayed as a dropdown again.
Closes #37118.
How to test the changes in this Pull Request:
Products>Add New>Product data>Inventory.Allow backorders?uses a radio button to set that option.selectinstead of theradiobuttons.Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: