New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added skydropx slug back to shipping partners list #37286
Conversation
bf3b88e
to
ad292e5
Compare
Test Results SummaryCommit SHA: ad292e5
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37286 +/- ##
==========================================
- Coverage 46.7% 46.7% -0.0%
- Complexity 17191 17197 +6
==========================================
Files 429 429
Lines 64845 64883 +38
==========================================
+ Hits 30275 30282 +7
- Misses 34570 34601 +31
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested well! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well in a JN with this plugin instead:
skydropx-cotizador-y-envios.zip
Details: p1679290917992459/1679042446.165109-slack-C01SFMVEYAK
Merging this now to make into the code freeze |
All Submissions:
Changes proposed in this Pull Request:
Previously the skydropx plugin was excluded from the shipping partners list as it was doing a redirect on activation, which then causes an error in the REST API call.
This has been remedied by them in the next version, which should be 1.0.7
Not too sure when they will release it but it will be out before 7.6 is released to public, so it should be safe to make this change before skydropx publishes it. In the unlikely event they do not release it, we will have to make a code freeze violation request to revert this commit.
How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: