Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added skydropx slug back to shipping partners list #37286

Merged
merged 1 commit into from Mar 20, 2023

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Mar 17, 2023

  • fix: added skydropx slug back to shipping partners list

All Submissions:

Changes proposed in this Pull Request:

Previously the skydropx plugin was excluded from the shipping partners list as it was doing a redirect on activation, which then causes an error in the REST API call.

This has been remedied by them in the next version, which should be 1.0.7

Not too sure when they will release it but it will be out before 7.6 is released to public, so it should be safe to make this change before skydropx publishes it. In the unlikely event they do not release it, we will have to make a code freeze violation request to revert this commit.

How to test the changes in this Pull Request:

  1. Set up a new site, go through OBW without installing any plugins. Set your location to Mexico
  2. If skydropx has published 1.0.7, ignore this step. Otherwise, only install this custom build of skydropx plugin without activating it. skydropx-cotizador-y-envios.zip
  3. Go to shipping task on the home screen and set up skydropx via the shipping task
  4. Should succeed without any errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 17, 2023
@rjchow rjchow requested review from a team, chihsuan and moon0326 March 17, 2023 08:30
@rjchow rjchow marked this pull request as ready for review March 17, 2023 08:30
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: ad292e5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1910010020114m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #37286 (ad292e5) into trunk (0cf5677) will decrease coverage by 0.0%.
The diff coverage is 19.6%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37286     +/-   ##
==========================================
- Coverage     46.7%    46.7%   -0.0%     
- Complexity   17191    17197      +6     
==========================================
  Files          429      429             
  Lines        64845    64883     +38     
==========================================
+ Hits         30275    30282      +7     
- Misses       34570    34601     +31     
Impacted Files Coverage Δ
plugins/woocommerce/includes/class-wc-ajax.php 4.3% <0.0%> (-<0.1%) ⬇️
...ugins/woocommerce/includes/class-wc-post-types.php 2.7% <0.0%> (-0.1%) ⬇️
...ludes/tracks/events/class-wc-settings-tracking.php 0.0% <0.0%> (ø)
...ocommerce/includes/abstracts/abstract-wc-order.php 86.6% <50.0%> (-0.1%) ⬇️
...gins/woocommerce/includes/wc-product-functions.php 44.7% <100.0%> (+1.0%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested well! 👍

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well in a JN with this plugin instead:

skydropx-cotizador-y-envios.zip

Details: p1679290917992459/1679042446.165109-slack-C01SFMVEYAK

@ilyasfoo
Copy link
Contributor

Merging this now to make into the code freeze

@ilyasfoo ilyasfoo merged commit a959b58 into trunk Mar 20, 2023
18 of 20 checks passed
@ilyasfoo ilyasfoo deleted the fix/skydropx-auto-install branch March 20, 2023 08:48
@github-actions github-actions bot added this to the 7.6.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants