Enable WebP images in WooCommerce #37307

anastas10s-afk · 2023-03-19T22:01:57Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

WebP files should be able to be imported in WooCommerce, as they've been supported in WordPress core since v5.8.

Adding this pull request, based on the following comments:

This is a first for me, hope all is in order. Cheers! 🙂
PS: I am aware that line 2609 could use alignment with the lines above it; can't see that I have an option to edit the code at this point in time, though.

Closes #28998.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
Have you included testing instructions?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

WebP files should be able to be imported in WooCommerce, as they've been supported in WordPress core since v5.8. Adding this pull request, based on the following comments: - woocommerce#28998 (comment) - woocommerce#28998 (comment) This is a first for me, hope all is in order. Cheers! 🙂

rrennick

@anastas10s-afk Thanks for submitting the PR. See my comments for the needed changes.

PS: I am aware that line 2609 could use alignment with the lines above it; can't see that I have an option to edit the code at this point in time, though.

A pull request isn't restricted to a single commit. If you notice you have missed something then you can fix it in your PR branch and push it to Github. Github will automatically update your PR.

The PR template has Closes # . in it. The reason we have that in the template is that Github will automatically close the issue if the PR description has Closes #ISSUENUMBER. Can you add that to your description.

Lastly, our process requires a changelog entry. You can create one with pnpm --filter=woocommerce changelog add. If you don't have pnpm running in your dev environment, let me know and I can add the changelog entry for you.

rrennick · 2023-03-21T17:37:43Z

plugins/woocommerce/includes/wc-core-functions.php

+	return $mime_to_ext;
+}
+
+function wc_rest_allowed_image_mime_types() {


This function already exists: https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/includes/wc-rest-functions.php#L47:L59

Adding a second definition will cause a fatal error. You need to edit the original function.

As I understand, I should go ahead with removing the whole function that I added (starting at line 2599), at wc-core-functions.php, and add 'webp' => 'image/webp', in line 57 at wc-rest-functions.php.

Correct?

I went ahead with doing so.

rrennick · 2023-03-21T17:38:54Z

plugins/woocommerce/includes/wc-core-functions.php

+ *
+ * WebP files should be able to be imported in WooCommerce, as they've been supported in WordPress core since v5.8.
+ */
+add_filter( 'woocommerce_rest_allowed_image_mime_types', 'more_mimes_to_exts' );


This filter isn't necessary if you are already adding webp to the array being passed to the filter.

Just to clarify, it is suggested to remove line 2592. Correct?

I went ahead with doing so.

Just to clarify, it is suggested to remove line 2592.

There is no need for the more_mimes_to_exts function as it was being called by the filter.

anastas10s-afk · 2023-03-21T20:27:52Z

A pull request isn't restricted to a single commit. If you notice you have missed something then you can fix it in your PR branch and push it to Github. Github will automatically update your PR.

TIL, thank you for this @rrennick.

The PR template has Closes # . in it. The reason we have that in the template is that Github will automatically close the issue if the PR description has Closes #ISSUENUMBER. Can you add that to your description.

Happily! Just to clarify, that would be Closes #28998 or Closes #37307, though?
Went ahead with Closes #28998.

Lastly, our process requires a changelog entry. You can create one with pnpm --filter=woocommerce changelog add. If you don't have pnpm running in your dev environment, let me know and I can add the changelog entry for you.

Kindly go ahead with adding the changelog entry for me, please. I do not have pnpm running in your dev environment. Thank you!

Removed, previously added, unnecessary filter, and already existing function in wc-rest-functions.php.

rrennick · 2023-03-22T13:44:06Z

Closes #37307

@anastas10s-afk Merging a PR closes it. The Closes # automation only works with issues. Once you have removed the unnecessary function this will be good to go.

anastas10s-afk · 2023-03-22T22:23:26Z

Closes #37307

@anastas10s-afk Merging a PR closes it. The Closes # automation only works with issues.

Noted. I went ahead with editing it to Closes #37307. now, thank you!

Once you have removed the unnecessary function this will be good to go.

@rrennick, as I understand the f2cd586 and bd2de5f commits are on point with fixing what is needed, and it is good to go? If otherwise, forgive me, could you reiterate on what would be needed from my end instead, please. Cheers!

rrennick · 2023-03-23T14:29:40Z

Noted. I went ahead with editing it to Closes #37307. now, thank you!

@anastas10s-afk Sorry if I wasn't clear. Adding Closes #37307 has no effect because this PR will be closed automatically when it is merged. Closes #28998 needs to be in the description for Github to close the issue when the PR is merged.

There is no need for the more_mimes_to_exts function as it was being called by the filter.

This needs to be addressed before the PR can be merged.

anastas10s-afk · 2023-03-23T17:39:17Z

There is no need for the more_mimes_to_exts function as it was being called by the filter.

This needs to be addressed before the PR can be merged.

I believe everything is set now, for the PR to be merged @rrennick.

To summarize this PR, I went ahead with removing all additions I previously made in /woocommerce/includes/wc-core-functions.php, at this commit, and kept only the one at /woocommerce/includes/wc-rest-functions.php - with this commit.

Cheers!

rapsli · 2023-04-04T07:42:07Z

any timeline on when this is live?

rrennick · 2023-04-05T14:17:07Z

@anastas10s-afk Could you merge the latest trunk into this branch? We have some failing tests that were fixed in trunk.

anastas10s-afk · 2023-04-06T18:29:56Z

@anastas10s-afk Could you merge the latest trunk into this branch? We have some failing tests that were fixed in trunk.

Happily ...if only I knew how to do so @rrennick. I cannot find my way around doing that merge, either the web interface or the desktop app, at GitHub. First-timer, my apologies.

anastas10s-afk · 2023-04-06T18:33:35Z

@rrennick any pointers would be very much appreciated, if possible.

codecov · 2023-04-06T18:36:43Z

Codecov Report

Merging #37307 (b0f042e) into trunk (817458a) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head b0f042e differs from pull request most recent head 0d93e92. Consider uploading reports for the commit 0d93e92 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             trunk   #37307     +/-   ##
==========================================
- Coverage     51.7%    51.6%   -0.0%     
  Complexity   17257    17257             
==========================================
  Files          429      429             
  Lines        79765    79828     +63     
==========================================
+ Hits         41200    41202      +2     
- Misses       38565    38626     +61

Impacted Files	Coverage Δ
plugins/woocommerce/includes/wc-rest-functions.php	`89.0% <100.0%> (+0.1%)`	⬆️

... and 3 files with indirect coverage changes

…upport

anastas10s-afk · 2023-04-06T18:42:13Z

@anastas10s-afk Could you merge the latest trunk into this branch? We have some failing tests that were fixed in trunk.

Quick update on this, @rrennick. From what I gather, I was able to do so?

rrennick · 2023-04-06T18:44:32Z

any pointers would be very much appreciated, if possible.

@anastas10s-afk I did this for you earlier today. In the future the way you would do it is update trunk in your fork to the latest trunk in this repo, merge trunk into your branch, then push to your origin.

anastas10s-afk · 2023-04-06T19:32:36Z

@anastas10s-afk I did this for you earlier today. In the future the way you would do it is update trunk in your fork to the latest trunk in this repo, merge trunk into your branch, then push to your origin.

Much appreciated, truly. A huge learning opportunity for me. Have a great one, @rrennick!

github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Mar 19, 2023

woocommercebot requested review from a team and rrennick and removed request for a team March 19, 2023 22:02

anastas10s-afk mentioned this pull request Mar 19, 2023

Webp Images not allowed even when allowd in Wordpress #28998

Closed

rrennick requested changes Mar 21, 2023

View reviewed changes

anastas10s-afk added 2 commits March 21, 2023 22:40

Updated WebP section in wc-core-functions.php

f2cd586

Removed, previously added, unnecessary filter, and already existing function in wc-rest-functions.php.

Added WebP support, at allowed_image_mime_types

bd2de5f

anastas10s-afk requested a review from rrennick March 21, 2023 20:56

Removed previously added unnecessary filter

e901ec1

Add changelog file

124bf3e

Merge branch 'trunk' into woocommerce-webp-support

b0f042e

Merge remote-tracking branch 'upstream/trunk' into woocommerce-webp-s…

0d93e92

…upport

rrennick approved these changes Apr 6, 2023

View reviewed changes

rrennick merged commit ac06ebd into woocommerce:trunk Apr 6, 2023
16 of 18 checks passed

github-actions bot added this to the 7.7.0 milestone Apr 6, 2023

anastas10s-afk deleted the woocommerce-webp-support branch April 7, 2023 07:39

rrennick mentioned this pull request Apr 25, 2023

Core product CSV importer: .webp cases invalid image error #37976

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable WebP images in WooCommerce #37307

Enable WebP images in WooCommerce #37307

anastas10s-afk commented Mar 19, 2023 •

edited

rrennick left a comment

rrennick Mar 21, 2023

anastas10s-afk Mar 21, 2023 •

edited

anastas10s-afk Mar 21, 2023

rrennick Mar 21, 2023

anastas10s-afk Mar 21, 2023

anastas10s-afk Mar 21, 2023

rrennick Mar 22, 2023

anastas10s-afk commented Mar 21, 2023 •

edited

rrennick commented Mar 22, 2023

anastas10s-afk commented Mar 22, 2023 •

edited

rrennick commented Mar 23, 2023

anastas10s-afk commented Mar 23, 2023 •

edited

rapsli commented Apr 4, 2023

rrennick commented Apr 5, 2023

anastas10s-afk commented Apr 6, 2023

anastas10s-afk commented Apr 6, 2023

codecov bot commented Apr 6, 2023 •

edited

anastas10s-afk commented Apr 6, 2023

rrennick commented Apr 6, 2023

anastas10s-afk commented Apr 6, 2023

Enable WebP images in WooCommerce #37307

Enable WebP images in WooCommerce #37307

Conversation

anastas10s-afk commented Mar 19, 2023 • edited

All Submissions:

Changes proposed in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

rrennick left a comment

Choose a reason for hiding this comment

rrennick Mar 21, 2023

Choose a reason for hiding this comment

anastas10s-afk Mar 21, 2023 • edited

Choose a reason for hiding this comment

anastas10s-afk Mar 21, 2023

Choose a reason for hiding this comment

rrennick Mar 21, 2023

Choose a reason for hiding this comment

anastas10s-afk Mar 21, 2023

Choose a reason for hiding this comment

anastas10s-afk Mar 21, 2023

Choose a reason for hiding this comment

rrennick Mar 22, 2023

Choose a reason for hiding this comment

anastas10s-afk commented Mar 21, 2023 • edited

rrennick commented Mar 22, 2023

anastas10s-afk commented Mar 22, 2023 • edited

rrennick commented Mar 23, 2023

anastas10s-afk commented Mar 23, 2023 • edited

rapsli commented Apr 4, 2023

rrennick commented Apr 5, 2023

anastas10s-afk commented Apr 6, 2023

anastas10s-afk commented Apr 6, 2023

codecov bot commented Apr 6, 2023 • edited

Codecov Report

anastas10s-afk commented Apr 6, 2023

rrennick commented Apr 6, 2023

anastas10s-afk commented Apr 6, 2023

anastas10s-afk commented Mar 19, 2023 •

edited

anastas10s-afk Mar 21, 2023 •

edited

anastas10s-afk commented Mar 21, 2023 •

edited

anastas10s-afk commented Mar 22, 2023 •

edited

anastas10s-afk commented Mar 23, 2023 •

edited

codecov bot commented Apr 6, 2023 •

edited