Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk sale price update #37812

Merged

Conversation

akshaya-rane
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Added numeric check for Regular price variable in bulk edits. A strict numeric check is not required. It passes the result.

Closes #37681.

How to test the changes in this Pull Request:

Thank you @lynnjat7 for listing the steps to reproduce the bug in detail. It helped to re-create the bug & fix it.

Using the WooCommerce Testing Instructions Guide, following points can be followed to test the fixes.

  1. Create a few simple products on the back end.

  2. Set a few products with blank Regular prices.

  3. When viewing the main Products list under Products, check off products to edit, including the one with the blank price.

  4. Click on Bulk Actions > Edit

  5. Select to edit the Sale price as "regular price decreased by" and enter some value with % as the discount.
    set-sale-price-via-bulk-edit

  6. Blank price product will remain as is. The rest of the products will get updated and Admin will view the success screen.

successful-product-update

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Apr 19, 2023
@woocommercebot woocommercebot requested review from a team and barryhughes and removed request for a team April 19, 2023 07:22
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This looks good; I'll wait for our required automated checks to pass then we can hopefully merge 👍

@barryhughes barryhughes merged commit afe226d into woocommerce:trunk Apr 21, 2023
17 of 18 checks passed
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Update on Sale Prices causes Fatal Error when Regular Price is blank
3 participants