Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the review-testing-instructions workflow on PR's from community contributors #37813

Merged
merged 2 commits into from Apr 19, 2023

Conversation

rodelgc
Copy link
Contributor

@rodelgc rodelgc commented Apr 19, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds the ability to skip the review-testing-instructions workflow when the PR is from an external contributor.
This would help unblock community PR's during the Contributor Day. See the issue reported here for context: p1681843624632139-slack-C03CPM3UXDJ

How to test the changes in this Pull Request:

Not sure if this PR could be tested, since the only way to test its changes is to have an external PR wanting to merge to trunk and the author requesting a review.

Maybe it's enough to verify that the Remind reviewers to also review the testing instructions. workflow in this PR passes.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 19, 2023
@rodelgc rodelgc added the focus: testing workflows Issues related to test related workflows (daily, release, merge to trunk etc). label Apr 19, 2023
@rodelgc rodelgc requested a review from a team April 19, 2023 07:44
@rodelgc rodelgc requested review from a team and removed request for a team April 19, 2023 07:56
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Hi @jonathansadowski, @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rodelgc rodelgc marked this pull request as ready for review April 19, 2023 08:10
@rodelgc rodelgc requested review from a team and jonathansadowski and removed request for a team April 19, 2023 08:10
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: dfb23ea

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests1870010019714m 20s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #37813 (dfb23ea) into trunk (e8fcfbb) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37813     +/-   ##
==========================================
- Coverage     51.5%    51.5%   -0.0%     
- Complexity   17261    17280     +19     
==========================================
  Files          429      430      +1     
  Lines        79957    80026     +69     
==========================================
  Hits         41215    41215             
- Misses       38742    38811     +69     

see 3 files with indirect coverage changes

Copy link
Contributor

@nigeljamesstevenson nigeljamesstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Del!

@nigeljamesstevenson nigeljamesstevenson merged commit 950bf93 into trunk Apr 19, 2023
22 of 23 checks passed
@nigeljamesstevenson nigeljamesstevenson deleted the fix/skip-test-instructions-community-prs branch April 19, 2023 11:19
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: testing workflows Issues related to test related workflows (daily, release, merge to trunk etc). plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants