remove unused deasync dependency #37821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Removes the
deasync
dependency, which seems to not be in use anymore. The package was causing a fatal build error duringpnpm install
when run from a path that contains spaces.Closes #31882.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
trunk
into a path with spaces, runnvm use
andpnpm install
and notice how it failsnvm use
andpnpm install
and notice how it does not faildeasync
, and since that is how one uses the package I assume the package isn't used anymore. please double-check this assumption.