New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TT3 styles and typography in the single product's attributes table #37895
Conversation
Hi @vedanshujain, @woocommerce/proton Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: ad5c577
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well.
I don't know what's the release process of WC core, but it might be good to copy-and-paste the testing instructions from #37639 changing the theme name into this PR. So that reduces the work the release lead needs to do when releasing.
Thanks for the review and the suggestion, @Aljullu! I've gone ahead and added testing instructions to the description! |
@xristos3490 Thanks for the PR.
Could you provide screenshots as you did in your TT2 PR? I didn't see any difference when switching to this branch. The centering issue and p margin didn't seem to be present in my dev install with TT3. |
Thanks for looking into this, @rrennick!
I've updated the issue description with some before&after screenshots.
That's true! The centering-issue isn't an issue in TT3. This PR mainly fixes the:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37895 +/- ##
==========================================
+ Coverage 51.2% 51.5% +0.3%
- Complexity 17439 17443 +4
==========================================
Files 440 440
Lines 80722 80290 -432
==========================================
+ Hits 41346 41347 +1
+ Misses 39376 38943 -433
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xristos3490 Thanks for the screenshots. This tested great for me.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Similar to:
https://github.com/woocommerce/woocommerce/pull/37639/files
This PR introduces styling improvements in the attributes table of the "Additional Information" product tab when viewing the single product template.
Before:
After:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: