Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TT3 styles and typography in the single product's attributes table #37895

Merged
merged 3 commits into from May 17, 2023

Conversation

xristos3490
Copy link
Member

@xristos3490 xristos3490 commented Apr 20, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Similar to:
https://github.com/woocommerce/woocommerce/pull/37639/files

This PR introduces styling improvements in the attributes table of the "Additional Information" product tab when viewing the single product template.

Before:
Before

After:
After

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create or use an existing site with TT3 (or Zaino)
  2. Ensure you have at least one product with multiple attribute values.
  3. Visit the single product's page and notice the styling issues in the attributes table in the Additional Information tab.
  4. Apply this patch, hard-refresh for CSS caching issues, and ensure the attributes table looks nice!

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

Hi @vedanshujain, @woocommerce/proton

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

Test Results Summary

Commit SHA: ad5c577

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 52s
E2E Tests1890010019919m 17s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@xristos3490 xristos3490 requested review from a team and vedanshujain and removed request for a team April 21, 2023 07:00
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

I don't know what's the release process of WC core, but it might be good to copy-and-paste the testing instructions from #37639 changing the theme name into this PR. So that reduces the work the release lead needs to do when releasing.

@xristos3490
Copy link
Member Author

Thanks for the review and the suggestion, @Aljullu! I've gone ahead and added testing instructions to the description!

@xristos3490 xristos3490 requested a review from a team May 8, 2023 09:32
@rrennick
Copy link
Contributor

@xristos3490 Thanks for the PR.

Visit the single product's page and notice the styling issues in the attributes table in the Additional Information tab.

Could you provide screenshots as you did in your TT2 PR? I didn't see any difference when switching to this branch. The centering issue and p margin didn't seem to be present in my dev install with TT3.

@rrennick rrennick added the focus: template Issue related to WooCommerce templates. label May 10, 2023
@xristos3490
Copy link
Member Author

Thanks for looking into this, @rrennick!

Could you provide screenshots as you did in your TT2 PR?

I've updated the issue description with some before&after screenshots.

The centering issue and p margin didn't seem to be present in my dev install with TT3.

That's true! The centering-issue isn't an issue in TT3. This PR mainly fixes the:

  • The spacing between the header rows (on the right); and
  • The p-margin issue.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #37895 (ad5c577) into trunk (6ed8fb4) will increase coverage by 0.3%.
The diff coverage is 58.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37895     +/-   ##
==========================================
+ Coverage     51.2%    51.5%   +0.3%     
- Complexity   17439    17443      +4     
==========================================
  Files          440      440             
  Lines        80722    80290    -432     
==========================================
+ Hits         41346    41347      +1     
+ Misses       39376    38943    -433     
Impacted Files Coverage Δ
...ommerce/includes/abstracts/abstract-wc-product.php 88.0% <0.0%> (-0.3%) ⬇️
...ins/woocommerce/includes/class-wc-form-handler.php 5.6% <0.0%> (-<0.1%) ⬇️
...ugins/woocommerce/includes/class-wc-post-types.php 1.8% <ø> (+0.8%) ⬆️
...woocommerce/includes/class-wc-product-variable.php 75.7% <0.0%> (-0.7%) ⬇️
...ins/woocommerce/includes/wc-template-functions.php 12.2% <0.0%> (-<0.1%) ⬇️
...lugins/woocommerce/includes/class-wc-countries.php 95.4% <100.0%> (ø)
...rs/Version2/class-wc-rest-orders-v2-controller.php 94.4% <100.0%> (ø)
...llers/Version3/class-wc-rest-orders-controller.php 80.5% <100.0%> (ø)
plugins/woocommerce/includes/wc-core-functions.php 63.6% <100.0%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xristos3490 Thanks for the screenshots. This tested great for me.

@rrennick rrennick merged commit d8eee11 into trunk May 17, 2023
19 checks passed
@rrennick rrennick deleted the fix/tt3-attributes-table branch May 17, 2023 19:37
@github-actions github-actions bot added this to the 7.8.0 milestone May 17, 2023
@xristos3490 xristos3490 self-assigned this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants