Track stock quantity for this product should be disabled when Enable stock management within settings is disabled, and enabled otherwise #37957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stock management within settings is disabled, and enabled otherwise.
github-actions
bot
added
the
plugin: woocommerce
|
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
joshuatf
approved these changes
Apr 24, 2023
| @@ -14,6 +14,10 @@ | |||
| }, | |||
| "property": { | |||
| "type": "string" | |||
| }, | |||
| "disabled": { | |||
| @@ -625,6 +625,7 @@ public static function register_post_types() { | |||
| array( | |||
| 'label' => __( 'Track stock quantity for this product', 'woocommerce' ), | |||
| 'property' => 'manage_stock', | |||
| 'disabled' => 'yes' !== get_option( 'woocommerce_manage_stock' ), | |||
There was a problem hiding this comment.
Just thinking about this in the future: once the settings screens are Reactified, we might want the ability to either:
a. Refetch this template (so we have the correct disabled property) OR
b. Move this setting check to the frontend
But this issue doesn't exist for the time being and I think punting it down the road is fine.
Test Results SummaryCommit SHA: a776c64
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #37888
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helperproduct-block-editorManage stockis active under/wp-admin/admin.php?page=wc-settings&tab=products§ion=inventorythenTrack stock quantity for this productunder/wp-admin/admin.php?page=wc-admin&path=/add-product&tab=inventoryshould be enabledManage stockis not active under/wp-admin/admin.php?page=wc-settings&tab=products§ion=inventorythenTrack stock quantity for this productunder/wp-admin/admin.php?page=wc-admin&path=/add-product&tab=inventoryshould be disabled