New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AdvancedFilters to use createInterpolateElement instead of interpolateComponents #37967
Conversation
Test Results SummaryCommit SHA: 6efa264
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
70c7dd1
to
f818b60
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37967 +/- ##
==========================================
- Coverage 51.5% 51.3% -0.2%
- Complexity 17281 17409 +128
==========================================
Files 430 440 +10
Lines 80030 80561 +531
==========================================
+ Hits 41215 41293 +78
- Misses 38815 39268 +453
|
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @mattsherman! LGTM 🚀
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates the
AdvancedFilters
component in@woocommerce/components
to usecreateInterpolateElement
from@wordpress/element
instead ofinterpolateComponents
from@automattic/interpolate-components
.Usage of
AdvancedFilters
inplugins/woocommerce-admin
has also been updated. Specially, the following screens are affected:WooCommerce
>Customers
Analytics
>Orders
Analytics
>Variations
Analytics
>Downloads
Each of those screens has a
Show
>Advanced filters
option that usesAdvancedFilters
.No functionality has been changed. The screens above should behavior exactly as they did before.
For example, here is what the
Analytics
>Orders
advanced filters look like:Part of #37312.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pnpm --filter=@woocommerce/storybook storybook
AdvancedFilters
>Basic
ReportFilters
>Examples
>Advanced filters
WooCommerce
>Customers
Analytics
>Orders
Analytics
>Variations
Analytics
>Downloads