Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 6 new countries in WCPay #38109

Merged
merged 9 commits into from Jun 27, 2023
Merged

Conversation

elazzabi
Copy link
Contributor

@elazzabi elazzabi commented May 4, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR adds onboarding support for 6 new countries in WCPay. Another PR with the same goal was added a few months ago.

This PR targets the next version of WC 7.8.0

How to test the changes in this Pull Request:

To trigger the OBW fallback, disable marketplace suggestions:
Settings > WooCommere.com > untick Display suggestions within WooCommerce

  1. Get this PR locally.
  2. Change your store location to one of the countries in this list (eg. Romania, Croatia, etc.).
  3. Trigger the WooCommerce onboarding wizard.
  4. Make sure WC Payments is showing as the suggested payment gateway in the "Set up payments" step.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Test Results Summary

Commit SHA: 18e41a0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 59s
E2E Tests1940010020416m 5s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@elazzabi elazzabi changed the title Add support for 6 new countries in WCPay Add support for 3 new countries in WCPay May 10, 2023
@elazzabi
Copy link
Contributor Author

elazzabi commented May 10, 2023

Following some internal project changes, we are dropping support for Czech Republic, Sweden, and Hungary for now. This has been done in 0a8309f. PR title and description updated accordingly.

This has been reverted. Going back to the 6 countries

@elazzabi elazzabi changed the title Add support for 3 new countries in WCPay Add support for 6 new countries in WCPay May 23, 2023
@elazzabi
Copy link
Contributor Author

Hey @adrianduffell 👋 Given you helped us with a prior PR (#36906) can you please help us with this one?

Thanks!

@github-actions
Copy link
Contributor

Hi @adrianduffell,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the ping @elazzabi !

@adrianduffell adrianduffell merged commit 2e5b6d1 into trunk Jun 27, 2023
18 checks passed
@adrianduffell adrianduffell deleted the add/intl-expansion-group2 branch June 27, 2023 10:35
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants