Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Upload a logo" step in Personalize task if theme doesn't support it #38161

Merged
merged 3 commits into from May 9, 2023

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented May 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #36334.

This PR hides the "Upload a logo" step in Personalize task if a theme doesn't support it by checking get_theme_support('custom-logo') value.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Use Twenty Twenty-Three theme
  2. Go to WooCommerce > Home and click on Personalize your store task from Task list
  3. Observe that "Upload a logo" step is not shown.
  4. Use Storefront theme
  5. Go to WooCommerce > Home and click on Personalize your store task from Task list
  6. Observe that "Upload a logo" step is shown.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 8, 2023
@chihsuan chihsuan self-assigned this May 8, 2023
@chihsuan chihsuan marked this pull request as ready for review May 8, 2023 10:48
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow May 8, 2023 10:48
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Test Results Summary

Commit SHA: 2030aff

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1870010019715m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple clean fix, tests well. Great work!🥇

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Thanks, @chihsuan. LGTM! 🚢

@chihsuan chihsuan merged commit 2189cb1 into trunk May 9, 2023
17 checks passed
@chihsuan chihsuan deleted the update/hide-logo-step-if-not-support branch May 9, 2023 10:20
@github-actions github-actions bot added this to the 7.8.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WooCommerce onboarding wizard displays Upload a logo for themes that don't support it
3 participants