Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activity panel not showing unread when closed #38173

Merged
merged 4 commits into from May 11, 2023
Merged

Conversation

nathanss
Copy link
Contributor

@nathanss nathanss commented May 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Fix activity panel not showing unread when closed.

I refactored some code and removed the && isPanelOpen clause from hasAbbreviatedNotificationsFn. Please review if that's actually needed for some reason, as it's passed to InboxPanel as a prop.

Closes #38139 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. In a fresh site with WooCommerce, hide both setup tasklist and “Things to do next” tasklist
  2. Create a new order with Processing status
  3. Go to a URL where "Activity" button appears (e.g. Product > Add) and toggle “Activity”, the red badge should appear with panel both open and closed.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 8, 2023
@nathanss nathanss requested a review from octaedro May 8, 2023 20:25
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Test Results Summary

Commit SHA: 321710b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202691m 11s
E2E Tests1880010019820m 50s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@nathanss nathanss marked this pull request as draft May 9, 2023 13:08
@octaedro octaedro marked this pull request as ready for review May 9, 2023 15:07
@octaedro octaedro marked this pull request as draft May 9, 2023 17:45
@nathanss nathanss marked this pull request as ready for review May 9, 2023 19:35
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #38173 (7cb059c) into trunk (c4c517c) will decrease coverage by 0.0%.
The diff coverage is 29.3%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #38173     +/-   ##
==========================================
- Coverage     51.2%    51.2%   -0.0%     
- Complexity   17421    17439     +18     
==========================================
  Files          440      440             
  Lines        80640    80708     +68     
==========================================
+ Hits         41312    41332     +20     
- Misses       39328    39376     +48     
Impacted Files Coverage Δ
...ocommerce/includes/abstracts/abstract-wc-order.php 76.4% <ø> (ø)
...ommerce/includes/abstracts/abstract-wc-product.php 88.3% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-addons.php 0.0% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-assets.php 0.0% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-status.php 14.5% <ø> (ø)
.../includes/admin/helper/class-wc-helper-updater.php 28.9% <ø> (ø)
...udes/admin/settings/class-wc-settings-products.php 98.6% <ø> (ø)
...lugins/woocommerce/includes/class-wc-countries.php 95.4% <ø> (ø)
plugins/woocommerce/includes/class-wc-coupon.php 73.9% <ø> (ø)
...woocommerce/includes/class-wc-frontend-scripts.php 0.0% <ø> (ø)
... and 14 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @nathanss! LGTM 🚀

@nathanss nathanss merged commit 345cca1 into trunk May 11, 2023
17 checks passed
@nathanss nathanss deleted the fix/activity-icon branch May 11, 2023 19:07
@github-actions github-actions bot added this to the 7.8.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity icon only shows red circle when panel is active
2 participants