New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix activity panel not showing unread when closed #38173
Conversation
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 321710b
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
…e from hasAbbreviatedNotifications logic
ad39ba4
to
7cb059c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38173 +/- ##
==========================================
- Coverage 51.2% 51.2% -0.0%
- Complexity 17421 17439 +18
==========================================
Files 440 440
Lines 80640 80708 +68
==========================================
+ Hits 41312 41332 +20
- Misses 39328 39376 +48
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @nathanss! LGTM 🚀
Submission Review Guidelines:
Changes proposed in this Pull Request:
Fix activity panel not showing unread when closed.
I refactored some code and removed the
&& isPanelOpen
clause fromhasAbbreviatedNotificationsFn
. Please review if that's actually needed for some reason, as it's passed toInboxPanel
as a prop.Closes #38139 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: