add: core profiler fetch extensions #38270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
rjchow
force-pushed
the
add/core-profiler-fetch-extensions
branch
from
0adba7f
to
c5d9f01
Compare
github-actions
bot
removed
the
plugin: woocommerce
Test Results SummaryCommit SHA: fed506a
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
rjchow
force-pushed
the
dev/add-core-profiler-state-tests
branch
from
29520cd
to
c7f46ff
Compare
moon0326
previously approved these changes
May 16, 2023
rjchow
force-pushed
the
add/core-profiler-fetch-extensions
branch
from
8f14774
to
bcc9cb9
Compare
github-actions
bot
added
the
plugin: woocommerce
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38270 +/- ##
==========================================
- Coverage 51.6% 51.5% -0.1%
+ Complexity 17444 17443 -1
==========================================
Files 440 440
Lines 80297 80291 -6
==========================================
- Hits 41401 41346 -55
- Misses 38896 38945 +49 |
rjchow
force-pushed
the
add/core-profiler-fetch-extensions
branch
from
bcc9cb9
to
acfb160
Compare
- prefetch it once in the machine init so that it's instant when used later - fetch it again in preExtensions state and store it to context - added prefetch for getCountries as well
rjchow
force-pushed
the
add/core-profiler-fetch-extensions
branch
from
acfb160
to
fed506a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Adds a prefetch call in the background for fetching extensions and countries in the init state without blocking the UI state.
This makes it so that subsequently when these calls are made, there won't be any loading time
Closes #37992.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Intermediate PR without user facing feature, QA testing not required