[Fix] Undefined array key 1, 2, 3 when using list to extract cookie values.

[fitimvata]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

• Check cookie parts length before checking if it is valid cookie.

How to test the changes in this Pull Request:

1. Add a product to cart
2. Check woocommerce cookie in browser debug console and modify wp_woocommerce_session_xxx cookie in such a way that format is not valid anymore. Ex: add random value abc
3. Reload the page.
4. The cart should be empty and session is not initialized.

[github-actions]

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[rrennick]

@fitimvata Thanks for the PR. We provide a template for contributors to complete when submitting a PR. Could you either edit the description of this PR and provide the missing information from the template or close this PR and create a new PR with the template filled out?

[fitimvata]

@rrennick that template i have used and removed parts that are not needed for this pr

[rrennick]

that template i have used and removed parts that are not needed for this pr

@fitimvata Unfortunately, we don't review incomplete pull requests. If you are unwilling/unable to provide us with the remaining information then I can close the PR.

[fitimvata]

@rrennick i have made pr before in woocommerce repo and are merged without a problem. If you want all the template fine i will make the changes.
But i think is more important to fix bugs than add unnecessary bureaucracy for this type of fixes.

I will let you know when i have updated this pr.

[fitimvata]

@rrennick I have updated the pull request description.

[rrennick]

I have updated the pull request description.

@fitimvata Thanks, I'll try to review this tomorrow.

[rrennick]

@fitimvata Thanks for your help on this. I've added a changelog so I'm waiting for tests to pass before merging.

[fitimvata]

@rrennick thanks