Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shipping class block to match new designs #38301

Merged
merged 3 commits into from May 15, 2023
Merged

Update shipping class block to match new designs #38301

merged 3 commits into from May 15, 2023

Conversation

mdperez86
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38044

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Got to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  2. Under Features tab make sure to enable product-block-editor
  3. Then visit /wp-admin/admin.php?page=wc-admin&path=/add-product
  4. Under Shipping tab make sure the Shipping class dropdown control follows the ACs described in Product Block Editor: Update shipping class block to match new designs #38044

@mdperez86 mdperez86 requested a review from a team May 15, 2023 16:20
@mdperez86 mdperez86 self-assigned this May 15, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 15, 2023
@github-actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and is testing well! All AC look good to me with the exception of the updated dropdown that we discussed tackling separately in our last grooming call.

LGTM! 🚢

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 41cc294

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 52s
E2E Tests1890010019929m 55s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mdperez86 mdperez86 merged commit 332094e into trunk May 15, 2023
19 checks passed
@mdperez86 mdperez86 deleted the add/38044 branch May 15, 2023 17:06
@github-actions github-actions bot added this to the 7.8.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Block Editor: Update shipping class block to match new designs
2 participants