Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down create-variable-product spec into smaller files #38335

Merged
merged 7 commits into from May 19, 2023

Conversation

rodelgc
Copy link
Contributor

@rodelgc rodelgc commented May 17, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR breaks down the huge create-variable-product spec into separate, more focused spec files. This would help in avoiding and troubleshooting flakiness in the future.

These specs are placed inside the new plugins/woocommerce/tests/e2e-pw/tests/merchant/products/add-variable-product/ folder as an initial step to group related specs together according to the critical flows they test.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Code review

  1. Make sure that none of the tests from the original create-variable-product spec got lost during the restructure.
  2. Make sure that the new specs do not use the deprecated page methods.

Test locally

  1. Run the setup commands for launching the local environment.
  2. cd into the plugins/woocommerce folder.
  3. Run the new specs in the add-variable-product folder. They should pass.
    pnpm test:e2e-pw add-variable-product
  4. Run the entire merchant E2E tests to see if the new specs conflict with any of the merchant tests.
    pnpm test:e2e-pw tests/e2e-pw/tests/merchant

Test on CI

  1. Rerun the E2E tests on CI a few times to make sure no flakiness were added.

@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 17, 2023
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 34dd147

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202691m 10s
E2E Tests1940010020415m 47s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #38335 (34dd147) into trunk (e077c4c) will not change coverage.
The diff coverage is 66.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             trunk   #38335   +/-   ##
========================================
  Coverage     51.6%    51.6%           
  Complexity   17444    17444           
========================================
  Files          440      440           
  Lines        80297    80297           
========================================
  Hits         41401    41401           
  Misses       38896    38896           
Impacted Files Coverage Δ
plugins/woocommerce/includes/class-woocommerce.php 20.0% <0.0%> (ø)
...cludes/data-stores/class-wc-webhook-data-store.php 78.5% <80.0%> (ø)

@rodelgc rodelgc marked this pull request as ready for review May 17, 2023 18:20
@rodelgc rodelgc requested a review from a team May 17, 2023 18:20
@github-actions
Copy link
Contributor

Hi , @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rodelgc rodelgc marked this pull request as draft May 17, 2023 18:30
@rodelgc rodelgc marked this pull request as ready for review May 18, 2023 02:17
Copy link
Contributor

@nigeljamesstevenson nigeljamesstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @rodelgc - thanks a lot for this! Fingers crossed this resolves a lot of the flakiness going forward 🤞

@nigeljamesstevenson nigeljamesstevenson merged commit f903feb into trunk May 19, 2023
21 checks passed
@nigeljamesstevenson nigeljamesstevenson deleted the e2e/breakdown-create-variable-spec branch May 19, 2023 14:38
@github-actions github-actions bot added this to the 7.8.0 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants