New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break down create-variable-product
spec into smaller files
#38335
Break down create-variable-product
spec into smaller files
#38335
Conversation
Test Results SummaryCommit SHA: 34dd147
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38335 +/- ##
========================================
Coverage 51.6% 51.6%
Complexity 17444 17444
========================================
Files 440 440
Lines 80297 80297
========================================
Hits 41401 41401
Misses 38896 38896
|
Hi , @woocommerce/solaris Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @rodelgc - thanks a lot for this! Fingers crossed this resolves a lot of the flakiness going forward 🤞
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR breaks down the huge
create-variable-product
spec into separate, more focused spec files. This would help in avoiding and troubleshooting flakiness in the future.These specs are placed inside the new
plugins/woocommerce/tests/e2e-pw/tests/merchant/products/add-variable-product/
folder as an initial step to group related specs together according to the critical flows they test.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Code review
create-variable-product
spec got lost during the restructure.page
methods.Test locally
cd
into theplugins/woocommerce
folder.add-variable-product
folder. They should pass.merchant
E2E tests to see if the new specs conflict with any of the merchant tests.Test on CI