Fix number of orders under tax report

[octaedro]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Under WooCommerce > Reports > Taxes, the number of orders displayed is incorrect. Currently, it shows the count of applied taxes instead of the actual number of orders that are charging taxes.

Before

After

Partially fixes issue 38347.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Set up a store with a tax plugin like Avalara Avatax.
2. Create a product and create an order. You may want to use a California address so multiple tax rules are applied.
3. Complete the order and make sure all the actions are run under WooCommerce > Status > Scheduled Actions
4. Go to WooCommerce > Reports > Taxes
5. Tax numbers should show correctly here.
6. Now checkout trunk, rebuild the project, and refresh the page.
7. The bug should be visible again.

[github-actions]

Test Results Summary

Commit SHA: da5ab47

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 52s
E2E Tests	195	0	0	10	0	205	15m 37s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @louwie17, @nathanss,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[louwie17]

Hey @octaedro thanks for digging into this, it looks like a fun one :)
I left a couple thoughts and suggestions on how to address this.
I think the underlying issue where the tax_rate is zero for Avatax is causing them all to loop together.

Speaking of tax_rate it looks like in our Analytics > Taxes table we are relying to much on wp_woocommerce_tax_rates table. So if a user deletes an old tax rate that data won't show up within the tax table in Analytics anymore. This is why when I enabled Avatax and deleted my other tax rates the table remained empty. As Avatax doesn't use the wp_woocommerce_tax_rates table.

I think we may want to use similar logic as the legacy reports tax page when displaying tax rates.

[louwie17]

Hey @octaedro thanks for digging into this, it looks like a fun one :)
I left a couple thoughts and suggestions on how to address this.
I think the underlying issue where the tax_rate is zero for Avatax is causing them all to loop together.

Speaking of tax_rate it looks like in our Analytics > Taxes table we are relying to much on wp_woocommerce_tax_rates table. So if a user deletes an old tax rate that data won't show up within the tax table in Analytics anymore. This is why when I enabled Avatax and deleted my other tax rates the table remained empty. As Avatax doesn't use the wp_woocommerce_tax_rates table.

I think we may want to use similar logic as the legacy reports tax page when displaying tax rates.

[nathanss]

Might be related to what @louwie17 found... But I found this bug when displaying "Last month" (there were no orders on that time period):

[louwie17]

Tested well, just left two minor comments, aside from that this will be good to go.

[nathanss]

The issue I found previously was fixed.

I have no comments regarding the code, and it seems Lourens already made a thorough review of it, so I'm approving it.

Lourens is AFK